From 31078e618fd7e02437d5ef5e6228aca496ae1bef Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Sun, 24 Oct 2021 03:59:10 +0100 Subject: [PATCH] chore(navigation/helm): attempt to get posframe working perfectly again Only outstanding issue is that some helm-completions when follow mode is enabled do not show the followed file content in the posframe. --- modules/navigation/siren-helm.el | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/modules/navigation/siren-helm.el b/modules/navigation/siren-helm.el index c1631af..21d7f38 100755 --- a/modules/navigation/siren-helm.el +++ b/modules/navigation/siren-helm.el @@ -194,13 +194,15 @@ :after (helm-global-bindings)) (use-package helm-posframe + :if window-system + :custom (helm-posframe-border-width 3) (helm-posframe-height nil) (helm-posframe-min-height 70) (helm-posframe-min-width nil) (helm-posframe-parameters '((left-fringe . 10) (right-fringe . 10))) - (helm-posframe-width 400) + (helm-posframe-width 500) :init ;; helm-posframe does not come with a minor mode to toggle it on/off, so let's @@ -208,7 +210,20 @@ (define-minor-mode helm-posframe-mode "Toggle helm-posframe." :lighter " fmt" - (if helm-posframe-mode (helm-posframe-enable) (helm-posframe-disable)))) + (if helm-posframe-mode (helm-posframe-enable) (helm-posframe-disable))) + + (defun siren-helm-posframe-clear-on-fullscreen (frame) + (let ((fullscreen (frame-parameter frame 'fullscreen))) + (when (and helm-posframe-mode + (memq fullscreen '(fullscreen fullboth))) + (posframe-hide-all)))) + + :config + (add-hook 'window-size-change-functions + 'siren-helm-posframe-clear-on-fullscreen) + + ;; (helm-posframe-mode +1) + ) (provide 'siren-helm) ;;; siren-helm.el ends here