From 70f776d4f3fe7761b2a4788107dff73e02d7b51c Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Tue, 30 Nov 2021 22:31:47 +0000 Subject: [PATCH] feat(version-control): add code-review package This allows reviewing GitHub pull requests within Emacs. --- core/siren-core-modules.el | 1 + modules/version-control/siren-code-review.el | 27 ++++++++++++++++++++ straight/versions/default.el | 6 ++++- 3 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 modules/version-control/siren-code-review.el diff --git a/core/siren-core-modules.el b/core/siren-core-modules.el index 6b5c4bf..8e968c5 100644 --- a/core/siren-core-modules.el +++ b/core/siren-core-modules.el @@ -119,6 +119,7 @@ (require 'siren-whitespace-cleanup) ;; Version control +(require 'siren-code-review) (require 'siren-diff-hl) (require 'siren-ediff) (require 'siren-forge) diff --git a/modules/version-control/siren-code-review.el b/modules/version-control/siren-code-review.el new file mode 100644 index 0000000..1dc3829 --- /dev/null +++ b/modules/version-control/siren-code-review.el @@ -0,0 +1,27 @@ +;;; siren-code-review.el --- jimeh's Emacs Siren: code-review configuration + +;;; Commentary: + +;; Basic configuration for code-review. + +;;; Code: + +(require 'siren-forge) + +(use-package code-review + :defer t + :custom + (code-review-db-database-file (expand-file-name + "code-review-db.sqlite" siren-cache-dir)) + (code-review-fill-column 80) + (code-review-lgtm-message "lgtm :)") + (code-review-new-buffer-window-strategy 'switch-to-buffer) + + :init + (with-eval-after-load 'forge + (transient-insert-suffix 'forge-dispatch '(1) + ["""Pull Request" + ("p r" "review at point" code-review-forge-pr-at-point)]))) + +(provide 'siren-code-review) +;;; siren-code-review.el ends here diff --git a/straight/versions/default.el b/straight/versions/default.el index b8f239e..cbffc40 100644 --- a/straight/versions/default.el +++ b/straight/versions/default.el @@ -1,4 +1,5 @@ -(("ace-window" . "c7cb315c14e36fded5ac4096e158497ae974bec9") +(("a.el" . "9ad2d18252b729174fe22ed0b2b7670c88f60c31") + ("ace-window" . "c7cb315c14e36fded5ac4096e158497ae974bec9") ("all-the-icons-ibuffer" . "f689582a413ba5bb722067ea470829819e1f1131") ("all-the-icons.el" . "483dba65e897071c156cefec937edcf51aa333db") ("anzu" . "5abb37455ea44fa401d5f4c1bdc58adb2448db67") @@ -11,6 +12,7 @@ ("centaur-tabs" . "8b4249c40581368faf7bb8e06f86b9eee199c3c6") ("cfrs" . "c1f639d7bfd3e728cf85dbe224b06a4be76158f4") ("closql" . "15f906c393db1a0fb6577afc3cf59466531eafef") + ("code-review" . "4427bfde0874f4a95b7c6c1df7fdf8cc343e6a9d") ("coffee-mode" . "35a41c7d8233eac0b267d9593e67fb8b6235e134") ("company-mode" . "6abb232acde15e1a7bf402a57f7bb982edf2de7d") ("company-nginx" . "82bdb730ad5971c594d9c99c069f3c7bb067897d") @@ -38,7 +40,9 @@ ("el-get" . "960f3fb962c35d3196bab20b2a3f6d6228119277") ("elisp-refs" . "c06aec4486c034d0d4efae98cb7054749f9cc0ec") ("emacs-async" . "5d365ffc6a2c2041657eaa5d762c395ea748c8d7") + ("emacs-deferred" . "2239671d94b38d92e9b28d4e12fd79814cfb9c16") ("emacs-doom-themes" . "96edc0ceb864b7d72218e58c8e9272cd96e5712c") + ("emacs-emojify" . "1b726412f19896abf5e4857d4c32220e33400b55") ("emacs-hcl-mode" . "e4d9eef631e8a386341ae8f94f7c2579586e65b5") ("emacs-htmlize" . "dd27bc3f26efd728f2b1f01f9e4ac4f61f2ffbf9") ("emacs-kv" . "721148475bce38a70e0b678ba8aa923652e8900e")