From 938f138ba86513aad3d3a18640cbc6b63cd5c6bc Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Wed, 5 Oct 2022 00:21:43 +0100 Subject: [PATCH] feat(ui): do not enable pixel-scroll-precision-mode on startup It sometimes causes a long lock-up of Emacs. I believe this is due to a known issue where the mode can cause excessive garbage collection while scrolling, combined with my use of gcmh which prevents GC while actively using Emacs. Hence my theory is that pixel scrolling is causing tons of memory to be consumed, but gcmh prevents the GC from running, until it hits a tipping point where it GCs hundreds of megabytes of memory. Or, that's my theory at least :P --- modules/ui/siren-pixel-scroll.el | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/modules/ui/siren-pixel-scroll.el b/modules/ui/siren-pixel-scroll.el index de41a33..7cbc0ed 100644 --- a/modules/ui/siren-pixel-scroll.el +++ b/modules/ui/siren-pixel-scroll.el @@ -38,10 +38,7 @@ (pixel-scroll-precision-mode -1) (setq scroll-margin siren-pixel-scroll--original-scroll-margin) (setq scroll-preserve-screen-position - siren-pixel-scroll--original-scroll-preserve-screen-position)))) - - :config - (siren-pixel-scroll-mode +1))) + siren-pixel-scroll--original-scroll-preserve-screen-position)))))) (provide 'siren-pixel-scroll) ;;; siren-pixel-scroll.el ends here