From f683ce205bf8f2a51bdb3d027e4fa786bcb11cb2 Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Sat, 17 Aug 2019 17:34:16 +0100 Subject: [PATCH] Don't use use-package to setup before-save hooks It causes the package to be lazy-loaded whenever the before-save hook runs, even if you've not used the package in question yet. --- modules/languages/siren-golang.el | 3 ++- modules/languages/siren-typescript.el | 7 +++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/modules/languages/siren-golang.el b/modules/languages/siren-golang.el index a87b68a..851d973 100644 --- a/modules/languages/siren-golang.el +++ b/modules/languages/siren-golang.el @@ -22,7 +22,6 @@ :hook (go-mode . siren-go-mode-setup) - (before-save . gofmt-before-save) :init (add-to-list 'projectile-globally-ignored-directories "Godeps") @@ -48,6 +47,8 @@ :config (message "loading go-mode") + (add-hook 'before-save-hook #'gofmt-before-save) + (when (memq window-system '(mac ns)) (exec-path-from-shell-copy-env "GOPATH")) diff --git a/modules/languages/siren-typescript.el b/modules/languages/siren-typescript.el index f1c0c90..ad934f8 100644 --- a/modules/languages/siren-typescript.el +++ b/modules/languages/siren-typescript.el @@ -38,7 +38,6 @@ (use-package tide :hook - ;; (before-save . tide-format-before-save) (typescript-mode . siren-tide-mode-setup) (web-mode . siren-tide-web-mode-setup) @@ -63,7 +62,11 @@ (flycheck-mode +1) (eldoc-mode +1) (tide-hl-identifier-mode +1) - (company-mode +1))) + (company-mode +1)) + + :config + ;; (add-hook 'before-save-hook #'tide-format-before-save) + ) (provide 'siren-typescript) ;;; siren-typescript.el ends here