mirror of
https://github.com/jimeh/.emacs.d.git
synced 2026-02-19 13:46:41 +00:00
feat(version-control): add github-review package
This serves as a alternative to the code-review package. I'm adding it mostly for testing purposes so I can compare the two and see the pros/cons with each.
This commit is contained in:
@@ -6,8 +6,6 @@
|
||||
|
||||
;;; Code:
|
||||
|
||||
(require 'siren-forge)
|
||||
|
||||
(use-package code-review
|
||||
:defer t
|
||||
:custom
|
||||
@@ -15,13 +13,7 @@
|
||||
"code-review-db.sqlite" siren-cache-dir))
|
||||
(code-review-fill-column 80)
|
||||
(code-review-lgtm-message "lgtm :)")
|
||||
(code-review-new-buffer-window-strategy 'switch-to-buffer)
|
||||
|
||||
:init
|
||||
(with-eval-after-load 'forge
|
||||
(transient-insert-suffix 'forge-dispatch '(1)
|
||||
["""Pull Request"
|
||||
("p r" "review at point" code-review-forge-pr-at-point)])))
|
||||
(code-review-new-buffer-window-strategy 'switch-to-buffer))
|
||||
|
||||
(provide 'siren-code-review)
|
||||
;;; siren-code-review.el ends here
|
||||
|
||||
@@ -6,7 +6,9 @@
|
||||
|
||||
;;; Code:
|
||||
|
||||
(require 'siren-code-review)
|
||||
(require 'siren-gh-notify)
|
||||
(require 'siren-github-review)
|
||||
(require 'siren-magit)
|
||||
|
||||
(use-package forge
|
||||
@@ -18,6 +20,10 @@
|
||||
"forge-database.sqlite" siren-cache-dir))
|
||||
|
||||
:config
|
||||
(transient-insert-suffix 'forge-dispatch '(1)
|
||||
["Pull Request"
|
||||
("p c" "code-review at point" code-review-forge-pr-at-point)
|
||||
("p g" "github-review at point" github-review-forge-pr-at-point)])
|
||||
(transient-insert-suffix 'forge-dispatch '(1)
|
||||
["GitHub"
|
||||
("g n" "notifications" gh-notify)]))
|
||||
|
||||
17
modules/version-control/siren-github-review.el
Normal file
17
modules/version-control/siren-github-review.el
Normal file
@@ -0,0 +1,17 @@
|
||||
;;; siren-github-review.el --- jimeh's Emacs Siren: github-review configuration
|
||||
|
||||
;;; Commentary:
|
||||
|
||||
;; Basic configuration for github-review.
|
||||
|
||||
;;; Code:
|
||||
|
||||
(use-package github-review
|
||||
:defer t
|
||||
:custom
|
||||
(github-review-fill-column 80)
|
||||
(github-review-lgtm-message "lgtm :)")
|
||||
(github-review-new-buffer-window-strategy 'switch-to-buffer))
|
||||
|
||||
(provide 'siren-github-review)
|
||||
;;; siren-github-review.el ends here
|
||||
Reference in New Issue
Block a user