Remove face overrides for oderless, vertico and selectrum. The defaults
from doom-themes are actually pretty nice once I gave them a chance :P
Also customize the built-in completions-common-part face so it matches
doom-themes' setup for orderless.
The doom-themes-set-faces essentially just lets you apply a doom-themes
faces spec against any theme you want.
Since we're defining a theme meant to override and extend various faces
from doom-themes, this makes it easier to do so, but also enables the
use of targeting light and dark theme variants with &light and &dark.
Turns out the conflicts with both copilot and highlight-indent-guide was
due to the newline-mark. Hence disable newline-mark and re-enable
whitespace mode.
Further tweaks to helm appearance, now simply take up the full frame
with it's completion UI. When follow mode is enabled, have preview
appear in bottom half of the window.
Some commands which output to compilation buffers did not get their
output colorized correctly by default. This ensures that terminal based
escape sequences are correctly handled.
Instead of manually just setting faces after loading a doom-themes
theme, let's use a custom override theme which we apply right after
applying any doom-themes theme.
The override theme uses various doom-color helpers, so the colors it
uses will be based on the most recently applied doom-themes theme.
I've been using doom-themes' doom-vibrant for long enough now that I'm
certain I won't be moving away from it anytime soon. So let's simplify
and strip away all other theme setup stuff.
Also create a new siren-display-line-numbers module and function that's
responsible for turning on the display of line numbers. Future changes
to how line numbers are displayed can now be done in a single place.
All siren modules lazy-load if they can, so there's no need to
lazy-require a siren module.
Also this avoids the annoyance of the first time you use a feature
it triggers a package install from melpa. All such things should
happen as part of Emacs startup.
