From ced2182076efafd73d55460d3c8e823e80712a54 Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Mon, 5 May 2025 13:42:44 +0100 Subject: [PATCH] chore(keybindings): disable custom tab override for now Cursor recently had some fixes for compatibility with Emacs keybinding extensions. And it seems to have fixed the issues I initially ran into. Lets comment out the custom tab keybinding for now, and see if there's any situations where I might still need it. --- keybindings.json | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/keybindings.json b/keybindings.json index 6a3e5f0..6353fe9 100644 --- a/keybindings.json +++ b/keybindings.json @@ -514,18 +514,20 @@ // MARK: Text Manipulation // =========================================================================== // - { // Set indentation to correct level. - // - // This was borrowed from the awesome-emacs-keymap extension and modified to - // add: - // - `!cpp.shouldAcceptTab` condition for the sake of Cursor. - // - `!tableMode` condition for the sake of text-tables. - // - // Extension: https://marketplace.visualstudio.com/items?itemName=tuttieee.emacs-mcx - "key": "tab", - "command": "emacs-mcx.tabToTabStop", - "when": "editorTextFocus && !editorReadonly && !inlineSuggestionVisible && !editorHoverFocused && !editorTabMovesFocus && !suggestWidgetVisible && !inSnippetMode && !editorTabCompletion && !editorParameterHintsVisible && !cursorAtInlineEdit && !cpp.shouldAcceptTab && !tableMode" - }, + // TODO: Re-evaluate if we may still need a custom tab keybinding for Cursor. + // + // { // Set indentation to correct level. + // // + // // This was borrowed from the awesome-emacs-keymap extension and modified to + // // add: + // // - `!cpp.shouldAcceptTab` condition for the sake of Cursor. + // // - `!tableMode` condition for the sake of text-tables. + // // + // // Extension: https://marketplace.visualstudio.com/items?itemName=tuttieee.emacs-mcx + // "key": "tab", + // "command": "emacs-mcx.tabToTabStop", + // "when": "editorTextFocus && !editorReadonly && !inlineSuggestionVisible && !editorHoverFocused && !editorTabMovesFocus && !suggestWidgetVisible && !inSnippetMode && !editorTabCompletion && !editorParameterHintsVisible && !cursorAtInlineEdit && !cpp.shouldAcceptTab && !tableMode" + // }, { // Cycle spacing. // // This is a basic emulation Emacs' built-in cycle-spacing command. It