2 Commits

Author SHA1 Message Date
7009d8c702 bump version to 0.2.1 2012-02-03 18:40:04 +00:00
c3300d264c hook into the airbrake gem in a cleaner and simpler way 2012-02-03 18:38:38 +00:00
3 changed files with 23 additions and 54 deletions

View File

@@ -1,21 +1,15 @@
module Airbrake module Airbrake
class << self class << self
def notify_with_statds(*args) private
def send_notice_with_statsd(*args)
Airbrake::Statsd.increment Airbrake::Statsd.increment
notify_without_statsd(*args) send_notice_without_statsd(*args)
end end
alias :notify_without_statsd :notify alias :send_notice_without_statsd :send_notice
alias :notify :notify_with_statds alias :send_notice :send_notice_with_statsd
def notify_or_ignore_with_statsd(*args)
Airbrake::Statsd.increment
notify_or_ignore_without_statsd(*args)
end
alias :notify_or_ignore_without_statsd :notify_or_ignore
alias :notify_or_ignore :notify_or_ignore_with_statsd
end end
end end

View File

@@ -1,5 +1,5 @@
module Airbrake module Airbrake
module Statsd module Statsd
VERSION = '0.2.0' VERSION = '0.2.1'
end end
end end

View File

@@ -4,58 +4,33 @@ describe Airbrake do
subject { Airbrake } subject { Airbrake }
it '#notify is an alias to #notify_with_statsd' do let(:notice) { mock('Notice', :to_xml => '') }
subject.method(:notify).should == subject.method(:notify_with_statds) let(:configuration) { mock('Configuration', :public? => true) }
let(:sender) do
sender = mock('Sender')
sender.stub(:send_to_airbrake)
sender
end end
it '#notify_or_ignore is an alias to #notify_or_ignore_with_statsd' do describe '#send_notice_without_statsd' do
subject.method(:notify_or_ignore). before do
should == subject.method(:notify_or_ignore_with_statsd) Airbrake.stub(:configuration).and_return(configuration)
end Airbrake.stub(:sender).and_return(sender)
end
describe '#notify_without_statsd' do
it 'does not call Airbrake::Statsd.increment' do it 'does not call Airbrake::Statsd.increment' do
Airbrake.stub(:send_notice).and_return(nil)
Airbrake.should_receive(:build_notice_for).with('oops', {})
Airbrake::Statsd.should_not_receive(:increment) Airbrake::Statsd.should_not_receive(:increment)
Airbrake.send(:send_notice_without_statsd, notice)
Airbrake.notify_without_statsd('oops', {})
end end
end end
describe '#notify' do describe '#send_notice' do
it 'calls Airbrake::Statsd.increment' do it 'calls Airbrake::Statsd.increment' do
Airbrake.stub(:send_notice).and_return(nil)
Airbrake.should_receive(:build_notice_for).with('oops', {})
Airbrake::Statsd.should_receive(:increment) Airbrake::Statsd.should_receive(:increment)
Airbrake.should_receive(:send_notice_without_statsd)
Airbrake.notify('oops', {}) Airbrake.send(:send_notice, notice)
end
end
describe '#notify_or_ignore_without_statsd' do
it 'does not call Airbrake::Statsd.increment' do
Airbrake.stub(:send_notice).and_return(nil)
Airbrake.should_receive(:build_notice_for).with('oops', {}).
and_return(mock('Notice', :ignore? => false))
Airbrake::Statsd.should_not_receive(:increment)
Airbrake.notify_or_ignore_without_statsd('oops', {})
end
end
describe '#notify_or_ignore' do
it 'calls Airbrake::Statsd.increment' do
Airbrake.stub(:send_notice).and_return(nil)
Airbrake.should_receive(:build_notice_for).with('oops', {}).
and_return(mock('Notice', :ignore? => false))
Airbrake::Statsd.should_receive(:increment)
Airbrake.notify_or_ignore('oops', {})
end end
end end