Compare commits

...

3 Commits
0.4.1 ... 0.4.2

3 changed files with 24 additions and 6 deletions

View File

@@ -2,6 +2,14 @@
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
### [0.4.2](https://github.com/jimeh/build-emacs-for-macos/compare/0.4.1...0.4.2) (2020-12-09)
### Bug Fixes
* **cli:** avoid error if --git-sha is used without a branch/tag/sha argument ([884f160](https://github.com/jimeh/build-emacs-for-macos/commit/884f1607f6707ca187b1abfb0ce562757d872230)), closes [#21](https://github.com/jimeh/build-emacs-for-macos/issues/21)
* **native_comp:** update env setup patch for recent changes to comp.el ([c7daa13](https://github.com/jimeh/build-emacs-for-macos/commit/c7daa1350bd69df172ce6484c54189d2cee8d97e))
### [0.4.1](https://github.com/jimeh/build-emacs-for-macos/compare/0.4.0...0.4.1) (2020-10-29) ### [0.4.1](https://github.com/jimeh/build-emacs-for-macos/compare/0.4.0...0.4.1) (2020-10-29)

View File

@@ -78,7 +78,7 @@ class Build
attr_reader :ref attr_reader :ref
attr_reader :options attr_reader :options
def initialize(root_dir, ref = 'master', options = {}) def initialize(root_dir, ref = nil, options = {})
@root_dir = root_dir @root_dir = root_dir
@ref = ref @ref = ref
@options = options @options = options
@@ -366,12 +366,12 @@ class Build
FileUtils.mkdir_p(builds_dir) FileUtils.mkdir_p(builds_dir)
metadata = [ metadata = [
ref.gsub(/\W/, '-'), meta[:ref]&.gsub(/\W/, '-'),
meta[:date], meta[:date],
meta[:sha][0..6], meta[:sha][0..6],
"macOS-#{OS.version}", "macOS-#{OS.version}",
OS.arch OS.arch
] ].compact
filename = "Emacs.app-[#{metadata.join('][')}].tbz" filename = "Emacs.app-[#{metadata.join('][')}].tbz"
target = "#{builds_dir}/#{filename}" target = "#{builds_dir}/#{filename}"
@@ -412,11 +412,13 @@ class Build
err "Failed to get commit info about: #{ref_sha}" if commit_json.nil? err "Failed to get commit info about: #{ref_sha}" if commit_json.nil?
commit = JSON.parse(commit_json) commit = JSON.parse(commit_json)
meta = {
@meta = {
sha: commit['sha'], sha: commit['sha'],
date: Date.parse(commit['commit']['committer']['date']) date: Date.parse(commit['commit']['committer']['date'])
} }
meta[:ref] = ref if ref && ref[0..6] != meta[:sha][0..6]
@meta = meta
end end
def http_get(url) def http_get(url)

View File

@@ -2,7 +2,7 @@ diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 25e2de9..bcedd31 100644 index 25e2de9..bcedd31 100644
--- a/lisp/emacs-lisp/comp.el --- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el
@@ -2801,6 +2801,45 @@ queued with LOAD %" @@ -2801,6 +2801,53 @@ queued with LOAD %"
(comp-run-async-workers) (comp-run-async-workers)
(message "Compilation started.")))) (message "Compilation started."))))
@@ -36,14 +36,22 @@ index 25e2de9..bcedd31 100644
+ ;; Remove advice, as it only needs to run once. + ;; Remove advice, as it only needs to run once.
+ (advice-remove 'native-compile + (advice-remove 'native-compile
+ 'native-compile-setup-environment-variables) + 'native-compile-setup-environment-variables)
+ (advice-remove 'comp--native-compile
+ 'native-compile-setup-environment-variables)
+ (advice-remove 'native-compile-async + (advice-remove 'native-compile-async
+ 'native-compile-setup-environment-variables)
+ (advice-remove 'native--compile-async
+ 'native-compile-setup-environment-variables)) + 'native-compile-setup-environment-variables))
+ +
+;; Ensure environment setup runs before any native compilation. +;; Ensure environment setup runs before any native compilation.
+(advice-add 'native-compile :before +(advice-add 'native-compile :before
+ 'native-compile-setup-environment-variables) + 'native-compile-setup-environment-variables)
+(advice-add 'comp--native-compile :before
+ 'native-compile-setup-environment-variables)
+(advice-add 'native-compile-async :before +(advice-add 'native-compile-async :before
+ 'native-compile-setup-environment-variables) + 'native-compile-setup-environment-variables)
+(advice-add 'native--compile-async :before
+ 'native-compile-setup-environment-variables)
+ +
(provide 'comp) (provide 'comp)