From 4e43aacaf1154c87839bb2da9a4a6eb5aeed6aa0 Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Sun, 16 Jan 2022 03:27:40 +0000 Subject: [PATCH] fix(xbar/brew-updates): upgrade all actions now only update listed packages Previously when upgrading all, no package names were passed in, meaning if a new package has become available since the xbar script last ran, that would be updated too. Now instead each listed package in the xbar menu is explicitly passed to brew. --- xbar/brew-updates.1h.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xbar/brew-updates.1h.rb b/xbar/brew-updates.1h.rb index 04db41e..e519f05 100755 --- a/xbar/brew-updates.1h.rb +++ b/xbar/brew-updates.1h.rb @@ -2,7 +2,7 @@ # frozen_string_literal: true # Brew Updates -# v2.2.1 +# v2.2.2 # Jim Myhrberg # jimeh # List and manage outdated Homebrew formulas and casks @@ -194,21 +194,23 @@ module Brew if formulas.size.positive? && casks.size.positive? printer.item( "Upgrade All (#{formulas.size + casks.size})", - terminal: true, refresh: true, shell: [brew_path, 'upgrade'] + terminal: true, refresh: true, + shell: [brew_path, 'upgrade'] + + formulas.map(&:name) + casks.map(&:name) ) end if formulas.size.positive? printer.item( "Upgrade All Formulas (#{formulas.size})", terminal: true, refresh: true, - shell: [brew_path, 'upgrade', '--formula'] + shell: [brew_path, 'upgrade', '--formula'] + formulas.map(&:name) ) end if casks.size.positive? printer.item( "Upgrade All Casks (#{casks.size})", terminal: true, refresh: true, - shell: [brew_path, 'upgrade', '--cask'] + shell: [brew_path, 'upgrade', '--cask'] + casks.map(&:name) ) end end