From cac78327bdcfddc701b35621f610274063ab0abc Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Fri, 2 Jul 2021 00:32:15 +0100 Subject: [PATCH] fix(native_comp): add gcc homebrew formula dependency Right now all *.eln files produced by native compilation links against a GCC shared library with a absolute file path, rather than to the version of the shared library included in the app bundle. This means for now we need to ensure the homebrew gcc formula is installed for native-compilation to work. More details are available here: https://github.com/jimeh/build-emacs-for-macos/issues/53 --- Casks/emacs-app-good.rb | 1 + Casks/emacs-app-nightly.rb | 1 + templates/emacs-app-good.rb.tpl | 1 + templates/emacs-app-nightly.rb.tpl | 1 + 4 files changed, 4 insertions(+) diff --git a/Casks/emacs-app-good.rb b/Casks/emacs-app-good.rb index 803dd2eb..a3f43267 100644 --- a/Casks/emacs-app-good.rb +++ b/Casks/emacs-app-good.rb @@ -36,6 +36,7 @@ cask 'emacs-app-good' do depends_on macos: '>= :catalina' depends_on arch: :intel + depends_on formula: 'gcc' app 'Emacs.app' binary "#{appdir}/Emacs.app/Contents/MacOS/bin/ebrowse" diff --git a/Casks/emacs-app-nightly.rb b/Casks/emacs-app-nightly.rb index 0c719486..e63960d1 100644 --- a/Casks/emacs-app-nightly.rb +++ b/Casks/emacs-app-nightly.rb @@ -36,6 +36,7 @@ cask 'emacs-app-nightly' do depends_on macos: '>= :catalina' depends_on arch: :intel + depends_on formula: 'gcc' app 'Emacs.app' binary "#{appdir}/Emacs.app/Contents/MacOS/bin/ebrowse" diff --git a/templates/emacs-app-good.rb.tpl b/templates/emacs-app-good.rb.tpl index 18536690..a9717f2c 100644 --- a/templates/emacs-app-good.rb.tpl +++ b/templates/emacs-app-good.rb.tpl @@ -36,6 +36,7 @@ cask 'emacs-app-good' do depends_on macos: '>= :catalina' depends_on arch: :intel + depends_on formula: 'gcc' app 'Emacs.app' binary "#{appdir}/Emacs.app/Contents/MacOS/bin/ebrowse" diff --git a/templates/emacs-app-nightly.rb.tpl b/templates/emacs-app-nightly.rb.tpl index 7455fb9a..f59ffc2c 100644 --- a/templates/emacs-app-nightly.rb.tpl +++ b/templates/emacs-app-nightly.rb.tpl @@ -36,6 +36,7 @@ cask 'emacs-app-nightly' do depends_on macos: '>= :catalina' depends_on arch: :intel + depends_on formula: 'gcc' app 'Emacs.app' binary "#{appdir}/Emacs.app/Contents/MacOS/bin/ebrowse"