From ffc71e6c1a96e7752fcee21f814b4035369b347c Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Sun, 20 Aug 2017 19:11:44 +0100 Subject: [PATCH] Remove git hooks While it's a good idea to ensure you don't commit or push anything broken, I believe that it should come down developer dicipline. Cause preventing commits if tests or linting fails, can and does get in the way of legitimate work, specially on non-master branches. --- Makefile | 9 --------- hook.sh | 8 -------- 2 files changed, 17 deletions(-) delete mode 100755 hook.sh diff --git a/Makefile b/Makefile index d44873d..c724dbc 100644 --- a/Makefile +++ b/Makefile @@ -1,15 +1,6 @@ NPM_EXECUTABLE_HOME := node_modules/.bin PATH := ${NPM_EXECUTABLE_HOME}:${PATH} -hooks: .git/hooks/pre-commit -hooks: .git/hooks/pre-push - -.git/hooks/pre-commit: hook.sh - cp $< $@ - -.git/hooks/pre-push: hook.sh - cp $< $@ - publish: npm-dep npm publish diff --git a/hook.sh b/hook.sh deleted file mode 100755 index b469f12..0000000 --- a/hook.sh +++ /dev/null @@ -1,8 +0,0 @@ -#!/usr/bin/env bash - -set -ex - -npm run lint -npm run test - -node package.json