From 2fdb51166cac9525c69fdda695d5609b4c046af5 Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Sun, 8 Jul 2018 01:38:18 +0100 Subject: [PATCH] Rename ObjectDump struct to Dump --- object_dump.go => dump.go | 16 ++++++++-------- leak_finder.go | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) rename object_dump.go => dump.go (77%) diff --git a/object_dump.go b/dump.go similarity index 77% rename from object_dump.go rename to dump.go index 1780728..70caffa 100644 --- a/object_dump.go +++ b/dump.go @@ -8,19 +8,19 @@ import ( "sort" ) -func NewObjectDump(file string) *ObjectDump { - return &ObjectDump{File: file} +func NewDump(file string) *Dump { + return &Dump{File: file} } -// ObjectDump contains all relevant data for a single heap dump. -type ObjectDump struct { +// Dump contains all relevant data for a single heap dump. +type Dump struct { File string Index []*string Entries map[string]*Entry } // Process processes the heap dump -func (s *ObjectDump) Process() error { +func (s *Dump) Process() error { file, err := os.Open(s.File) defer file.Close() @@ -54,7 +54,7 @@ func (s *ObjectDump) Process() error { return nil } -func (s *ObjectDump) PrintEntryAddress(indexes []*string) { +func (s *Dump) PrintEntryAddress(indexes []*string) { for _, index := range indexes { if entry, ok := s.Entries[*index]; ok { fmt.Println(entry.Address()) @@ -62,7 +62,7 @@ func (s *ObjectDump) PrintEntryAddress(indexes []*string) { } } -func (s *ObjectDump) PrintEntryJSON(indexes []*string) error { +func (s *Dump) PrintEntryJSON(indexes []*string) error { file, err := os.Open(s.File) defer file.Close() @@ -92,7 +92,7 @@ func (s *ObjectDump) PrintEntryJSON(indexes []*string) error { return nil } -func (s *ObjectDump) sortedOffsets(indexes []*string) []int64 { +func (s *Dump) sortedOffsets(indexes []*string) []int64 { var res []int64 for _, index := range indexes { diff --git a/leak_finder.go b/leak_finder.go index 3c52bea..f7a61b6 100644 --- a/leak_finder.go +++ b/leak_finder.go @@ -10,7 +10,7 @@ func NewLeakFinder(file1, file2, file3 string) *LeakFinder { type LeakFinder struct { FilePaths [3]string - Dumps [3]*ObjectDump + Dumps [3]*Dump Leaks []*string Verbose bool } @@ -18,7 +18,7 @@ type LeakFinder struct { func (s *LeakFinder) Process() error { for i, filePath := range s.FilePaths { s.log(fmt.Sprintf("Parsing %s", filePath)) - dump := NewObjectDump(filePath) + dump := NewDump(filePath) err := dump.Process() if err != nil {