parsecsv/parsecsv-for-php
1
0
Fork 0
mirror of https://github.com/parsecsv/parsecsv-for-php.git synced 2026-02-19 08:36:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extend test coverage to PHP 8.3

Browse Source
This commit is contained in:
Christian Bläul
2024-08-29 17:05:04 +02:00
parent 27ab8a3e05
commit 259e9a6c31
7 changed files with 69 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/methods/DataRowCountTest.php
View File

@@ -21,7 +21,7 @@ class DataRowCountTest extends TestCase {
$this->csv = new Csv();
}
public function countRowsProvider() {
public static function countRowsProvider() {
return [
'auto-double-enclosure' => [
'auto-double-enclosure.csv',

4
tests/methods/ParseTest.php
View File

@@ -63,7 +63,7 @@ class ParseTest extends TestCase {
/**
* @return array
*/
public function autoDetectionProvider() {
public static function autoDetectionProvider() {
return [
'UTF8_no_BOM' => [__DIR__ . '/../example_files/UTF-8_sep_row_but_no_BOM.csv'],
'UTF8' => [__DIR__ . '/../example_files/UTF-8_with_BOM_and_sep_row.csv'],
@@ -294,7 +294,7 @@ class ParseTest extends TestCase {
/**
* @return array
*/
public function autoQuotesDataProvider(): array {
public static function autoQuotesDataProvider(): array {
return array(
array('auto-double-enclosure.csv', '"'),
array('auto-single-enclosure.csv', "'"),

2
tests/properties/OffsetTest.php
View File

@@ -25,7 +25,7 @@ class OffsetTest extends BaseClass {
$this->assertEquals($expected, $actual);
}
public function numberRangeZeroToFourProvider() {
public static function numberRangeZeroToFourProvider() {
return array_map(function ($number) {
return [$number];
}, range(0, 4));

2
tests/properties/SortByTest.php
View File

@@ -7,7 +7,7 @@ class SortByTest extends BaseClass {
public function testSortByRating() {
$this->csv->sort_by = 'rating';
$this->csv->conditions = 'title does not contain Blood';
if (!preg_match('/^8\.2\./', phpversion()))
if (!preg_match('/^8\.2\./', phpversion()) && !preg_match('/^8\.3\./', phpversion()))
$this->_compareWithExpected([
// Rating 0
'The Killing Kind',

17
tests/rector.php Normal file
View File

@@ -0,0 +1,17 @@
<?php
declare(strict_types=1);
use Rector\Config\RectorConfig;
use Rector\PHPUnit\CodeQuality\Rector\Class_\AddCoversClassAttributeRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\ClassMethod\DataProviderAnnotationToAttributeRector;
use Rector\PHPUnit\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector;
use Rector\PHPUnit\AnnotationsToAttributes\Rector\ClassMethod\DependsAnnotationWithValueToAttributeRector;
use \Rector\Php80\Rector\Class_\AnnotationToAttributeRector;
return static function(RectorConfig $rectorConfig): void {
$rectorConfig->rule(AddCoversClassAttributeRector::class);
$rectorConfig->rule(DataProviderAnnotationToAttributeRector::class);
$rectorConfig->rule(AddDoesNotPerformAssertionToNonAssertingTestRector::class);
$rectorConfig->rule(DependsAnnotationWithValueToAttributeRector::class);
};