mirror of
https://github.com/parsecsv/parsecsv-for-php.git
synced 2026-02-19 08:36:39 +00:00
Renamed class to follow the PHP community guidelines such as:
- https://svn.apache.org/repos/asf/shindig/attic/php/docs/style-guide.html: "Acryonyms are treated as normal words." - https://softwareengineering.stackexchange.com/a/149321/80632 Overview of class naming conventions of PHP frameworks - https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-4-autoloader.md No .lib allowed: "The class name corresponds to a file name ending in .php" See issue #50
This commit is contained in:
@@ -7,7 +7,7 @@ class BaseClass extends PHPUnit\Framework\TestCase {
|
||||
* The parseCSV object
|
||||
*
|
||||
* @access protected
|
||||
* @var parseCSV
|
||||
* @var ParseCsvForPhp
|
||||
*/
|
||||
protected $csv;
|
||||
|
||||
@@ -18,7 +18,7 @@ class BaseClass extends PHPUnit\Framework\TestCase {
|
||||
* @access public
|
||||
*/
|
||||
public function setUp() {
|
||||
$this->csv = new parseCSV();
|
||||
$this->csv = new ParseCsvForPhp();
|
||||
}
|
||||
|
||||
protected function _compareWithExpected($expected) {
|
||||
|
||||
@@ -7,7 +7,7 @@ class default_values_properties_Test extends PHPUnit\Framework\TestCase {
|
||||
* The parseCSV object
|
||||
*
|
||||
* @access protected
|
||||
* @var [parseCSV]
|
||||
* @var ParseCsvForPhp
|
||||
*/
|
||||
protected $csv = null;
|
||||
|
||||
@@ -19,7 +19,7 @@ class default_values_properties_Test extends PHPUnit\Framework\TestCase {
|
||||
*/
|
||||
public function setUp() {
|
||||
//setup parse CSV
|
||||
$this->csv = new parseCSV();
|
||||
$this->csv = new ParseCsvForPhp();
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -7,7 +7,7 @@ class worthless_properties_Test extends PHPUnit\Framework\TestCase {
|
||||
* The parseCSV object
|
||||
*
|
||||
* @access protected
|
||||
* @var [parseCSV]
|
||||
* @var ParseCsvForPhp
|
||||
*/
|
||||
protected $csv = null;
|
||||
|
||||
@@ -16,7 +16,7 @@ class worthless_properties_Test extends PHPUnit\Framework\TestCase {
|
||||
* The reflection class object
|
||||
*
|
||||
* @access protected
|
||||
* @var [ReflectionClass]
|
||||
* @var ReflectionClass
|
||||
*/
|
||||
protected $reflection = null;
|
||||
|
||||
@@ -25,6 +25,7 @@ class worthless_properties_Test extends PHPUnit\Framework\TestCase {
|
||||
* The reflected class properties
|
||||
*
|
||||
* @access protected
|
||||
* @var ReflectionProperty[]
|
||||
*/
|
||||
protected $properties = null;
|
||||
|
||||
@@ -36,7 +37,7 @@ class worthless_properties_Test extends PHPUnit\Framework\TestCase {
|
||||
*/
|
||||
public function setUp() {
|
||||
//setup parse CSV
|
||||
$this->csv = new parseCSV();
|
||||
$this->csv = new ParseCsvForPhp();
|
||||
|
||||
//setup the reflection class
|
||||
$this->reflection = new ReflectionClass($this->csv);
|
||||
@@ -107,7 +108,7 @@ class worthless_properties_Test extends PHPUnit\Framework\TestCase {
|
||||
'error',
|
||||
'error_info',
|
||||
'titles',
|
||||
'data'
|
||||
'data',
|
||||
);
|
||||
|
||||
// Find our real properties
|
||||
@@ -129,7 +130,7 @@ class worthless_properties_Test extends PHPUnit\Framework\TestCase {
|
||||
public function test_count_public_properties() {
|
||||
$counter = 0;
|
||||
|
||||
for ($a = 0; $a < count($this->properties); $a++) {
|
||||
for ($a = count($this->properties) - 1; $a >= 0; $a--) {
|
||||
if ($this->properties[$a]->isPublic() === true) {
|
||||
$counter++;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user