From 5ca540daa74d1a0325d8d720b41014d726dfa81a Mon Sep 17 00:00:00 2001 From: Fonata Date: Sat, 14 Sep 2019 01:18:29 +0200 Subject: [PATCH] Avoid PhpStorm inspection for $value{0} on empty string (prevent E_NOTICE) Here, $value is not empty, but the PhpStorm inspection doesn't get that. I want to have zero warnings for this library. --- src/Csv.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Csv.php b/src/Csv.php index ff62dc3..893e3f0 100644 --- a/src/Csv.php +++ b/src/Csv.php @@ -1103,7 +1103,7 @@ class Csv { : ''; $enclosure_quoted = preg_quote($this->enclosure, '/'); $pattern = "/" . $delimiter_quoted . $enclosure_quoted . "|\n|\r/i"; - if ($this->enclose_all || preg_match($pattern, $value) || ($value{0} == ' ' || substr($value, -1) == ' ')) { + if ($this->enclose_all || preg_match($pattern, $value) || (strpos($value, ' ') === 0 || substr($value, -1) == ' ')) { $value = str_replace($this->enclosure, $this->enclosure . $this->enclosure, $value); $value = $this->enclosure . $value . $this->enclosure; }