diff --git a/ChangeLog.txt b/ChangeLog.txt index 6524d10..a8845b1 100644 --- a/ChangeLog.txt +++ b/ChangeLog.txt @@ -1,3 +1,16 @@ +ParseCSV 1.3.1 +----------------------------------- +Date: to be released + +Bugfix: +- `parseFile()` will now set `$csv->data`. + Until now, the parsed data was only returned. + This adds consistency with `$csv->parse()` + for the following operations on the object. + +----------------------------------- + + ParseCSV 1.3.0 ----------------------------------- Date: 14-Apr-2021 diff --git a/src/Csv.php b/src/Csv.php index b423b23..d42dcf9 100644 --- a/src/Csv.php +++ b/src/Csv.php @@ -621,7 +621,10 @@ class Csv { return false; } - return !empty($this->file_data) ? $this->_parse_string() : false; + if (empty($this->file_data)) { + return false; + } + return $this->data = $this->_parse_string(); } /** diff --git a/tests/methods/ParseTest.php b/tests/methods/ParseTest.php index 7687b1a..b3dd239 100644 --- a/tests/methods/ParseTest.php +++ b/tests/methods/ParseTest.php @@ -331,4 +331,10 @@ class ParseTest extends TestCase { self::assertFalse($this->csv->parseFile('')); self::assertFalse($this->csv->parseFile(null)); } + + public function testParseFile() { + $data = $this->csv->parseFile(__DIR__ . '/fixtures/auto-double-enclosure.csv'); + self::assertCount(2, $data); + self::assertEquals($data, $this->csv->data); + } }