From 9e5c97328d88fd6d8f80f44a7ddb779dd79f767b Mon Sep 17 00:00:00 2001 From: Susann Sgorzaly Date: Mon, 26 Feb 2018 08:33:09 +0100 Subject: [PATCH] renamed function to getTotalDataRowCount --- src/Csv.php | 2 +- tests/methods/ParseTest.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Csv.php b/src/Csv.php index 5a07658..49ba372 100644 --- a/src/Csv.php +++ b/src/Csv.php @@ -547,7 +547,7 @@ class Csv { * * @return bool|int */ - public function getTotalRowCount() { + public function getTotalDataRowCount() { if (empty($this->file_data)) { return false; } diff --git a/tests/methods/ParseTest.php b/tests/methods/ParseTest.php index c81876a..5851438 100644 --- a/tests/methods/ParseTest.php +++ b/tests/methods/ParseTest.php @@ -225,7 +225,7 @@ class ParseTest extends TestCase public function testGetTotalRowCountFromFile($file, $expectedRows){ $this->csv->heading = true; $this->csv->load_data(__DIR__ . '/fixtures/' . $file); - $this->assertEquals($expectedRows, $this->csv->getTotalRowCount()); + $this->assertEquals($expectedRows, $this->csv->getTotalDataRowCount()); } public function testGetTotalRowCountMissingEndingLineBreak(){ @@ -233,6 +233,6 @@ class ParseTest extends TestCase $this->csv->enclosure = '"'; $sInput = "86545235689,a\r\n34365587654,b\r\n13469874576,\"c\r\nd\""; $this->csv->load_data($sInput); - $this->assertEquals(3, $this->csv->getTotalRowCount()); + $this->assertEquals(3, $this->csv->getTotalDataRowCount()); } }