parsecsv/parsecsv-for-php
1
0
Fork 0
mirror of https://github.com/parsecsv/parsecsv-for-php.git synced 2026-02-19 08:36:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes unparse bug if array ids doesn't begin on zero (comments#149)

Browse Source
This commit is contained in:
Susann Sgorzaly
2018-11-13 18:53:08 +01:00
committed by Fonata
parent 8aa61914f7
commit ab9e8a0af9
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Csv.php
View File

@@ -846,7 +846,7 @@ class Csv {
} }
// this is needed because sometime titles property is overwritten instead of using fields parameter! // this is needed because sometime titles property is overwritten instead of using fields parameter!
$titlesOnParse = !empty($this->data) ? array_keys($this->data[0]) : array(); $titlesOnParse = !empty($this->data) ? array_keys(reset($this->data)) : array();
// both are identical, also in ordering // both are identical, also in ordering
if (array_values($fields) === array_values($titlesOnParse)) { if (array_values($fields) === array_values($titlesOnParse)) {

6
tests/methods/UnparseTest.php
View File

@@ -75,6 +75,12 @@ class UnparseTest extends Testcase {
$this->unparseAndCompare($expected, $fields); $this->unparseAndCompare($expected, $fields);
} }
public function testUnparseDefaultFirstRowMissing(){
unset($this->csv->data[0]);
$expected = "column1,column2\rvalue3,value4\r";
$this->unparseAndCompare($expected);
}
private function unparseAndCompare($expected, $fields = array()) { private function unparseAndCompare($expected, $fields = array()) {
$str = $this->csv->unparse($this->csv->data, $fields); $str = $this->csv->unparse($this->csv->data, $fields);
$this->assertEquals($expected, $str); $this->assertEquals($expected, $str);