Dropping PHP 5.4 support (#131)

Also removed special treatment of PHP 5.4, as we don't support it anymore
This commit is contained in:
Fonata
2018-03-20 11:12:22 +01:00
committed by GitHub
parent f24e5bf3a3
commit e6ba24b47a
4 changed files with 4 additions and 19 deletions

View File

@@ -6,7 +6,6 @@ php:
- 7.0 - 7.0
- 5.6 - 5.6
- 5.5 - 5.5
- 5.4
script: script:
- phpunit --version - phpunit --version

View File

@@ -5,6 +5,8 @@ Date: unreleased
- New function getTotalDataRowCount() - useful if - New function getTotalDataRowCount() - useful if
$limit is set - see pull request #122. $limit is set - see pull request #122.
- Dropped support for PHP 5.4
----------------------------------- -----------------------------------

View File

@@ -26,7 +26,7 @@ and third-party support for handling CSV data in PHP.
how different programs like Excel for example outputs CSV data. how different programs like Excel for example outputs CSV data.
* Support for character encoding conversion using PHP's * Support for character encoding conversion using PHP's
`iconv()` and `mb_convert_encoding()` functions. `iconv()` and `mb_convert_encoding()` functions.
* Supports PHP 5.4 and higher. * Supports PHP 5.5 and higher.
It certainly works with PHP 7.2 and all versions in between. It certainly works with PHP 7.2 and all versions in between.
## Installation ## Installation

View File

@@ -108,10 +108,6 @@ class ParseTest extends TestCase {
} }
public function test_Piwik_data() { public function test_Piwik_data() {
if (!function_exists('array_column')) {
// function only available in PHP >= 5.5
return;
}
$this->csv->use_mb_convert_encoding = true; $this->csv->use_mb_convert_encoding = true;
$this->csv->output_encoding = 'UTF-8'; $this->csv->output_encoding = 'UTF-8';
$this->csv->auto(__DIR__ . '/../example_files/Piwik_API_download.csv'); $this->csv->auto(__DIR__ . '/../example_files/Piwik_API_download.csv');
@@ -134,12 +130,6 @@ class ParseTest extends TestCase {
* @depends testSepRowAutoDetection * @depends testSepRowAutoDetection
*/ */
public function testGetColumnDatatypes() { public function testGetColumnDatatypes() {
if (!function_exists('array_column')) {
// getDatatypes requires array_column, but that
// function is only available in PHP >= 5.5
return;
}
$this->csv->auto(__DIR__ . '/fixtures/datatype.csv'); $this->csv->auto(__DIR__ . '/fixtures/datatype.csv');
$this->csv->getDatatypes(); $this->csv->getDatatypes();
$expected = [ $expected = [
@@ -157,13 +147,7 @@ class ParseTest extends TestCase {
/** /**
* @depends testSepRowAutoDetection * @depends testSepRowAutoDetection
*/ */
public function testAutoDetectFileHasHeading(){ public function testAutoDetectFileHasHeading() {
if (!function_exists('array_column')) {
// getDatatypes requires array_column, but that
// function is only available in PHP >= 5.5
return;
}
$this->csv->auto(__DIR__ . '/fixtures/datatype.csv'); $this->csv->auto(__DIR__ . '/fixtures/datatype.csv');
$this->assertTrue($this->csv->autoDetectFileHasHeading()); $this->assertTrue($this->csv->autoDetectFileHasHeading());