Christian Bläul
631fae5191
Improved PHPDoc of _check_count; Refactored vars in _guess_delimiter
...
This commit does not contain functional changes.
2018-01-21 01:15:56 +01:00
Christian Bläul
18ddde98c0
Comparison in _enclose_value: put least expensive condition first
2018-01-21 01:15:56 +01:00
Christian Bläul
a07de14bba
Slightly more meaningful variable names in 'unparse' function
2018-01-21 01:15:56 +01:00
Christian Bläul
e87a5ae0e6
Improved source code formatting (no functional change)
2018-01-21 01:15:56 +01:00
Christian Bläul
c04fc89c43
Removed @access PHPDoc because it doesn't add value.
...
Today's phpDocumentor detects visiblity from the PHP keywords.
2018-01-21 01:15:56 +01:00
Christian Bläul
cc908fd096
_detect_and_remove_sep_row_from_data: improved comments to make it more ...
...
obvious that $data given is changed.
2018-01-21 01:15:56 +01:00
Christian Bläul
155c50ad7a
Slightly improved code quality, no functionality changes
...
E.g.:
- Improved PHPDoc to reflect/include actual types
- Removed unnecessary brackets in ternary statements
- _check_count: Added return statement (code smell)
- added type-safe comparison where it doesn't change results
2018-01-21 01:15:56 +01:00
Christian Bläul
0ac5064d58
Only call iconv if input and output encoding differ.
...
This saves some headache if characters are invalid according to iconv.
2017-12-21 09:33:23 +01:00
Christian Bläul
4d011827f5
When we find a BOM, we know the input encoding. Let's use it!
...
Also: UTF tests not failing anymore because we are specifying
the output encoding now.
2017-12-21 09:33:23 +01:00
Christian Bläul
c818fff81a
Only improved spelling in source code comments
2017-12-21 09:33:23 +01:00
Matthew de Marillac
ccad5c8360
Remove BOM from UTF files.
...
Implementation similar to suggestion from, and thus closes #83
2017-12-21 09:33:23 +01:00
Christian Bläul
0d14ca01be
Improved sep= detection and added it to auto()
2017-12-06 02:25:54 +01:00
Christian Bläul
a4a0dfa2fd
Extracted the long detection algorithm from 'auto()' into new function.
...
Also removed unnecessary brackets () in ternary on the way.
2017-12-06 02:25:54 +01:00
Christian Bläul
f5851ba9ac
Only improved comments in source code
2017-12-06 02:25:54 +01:00
Jan Piskvor Martinec
fad5ebcdc8
Added function to detect delimiter using sep= file header
2017-12-06 02:25:54 +01:00
Salem Ouerdani
1321c3b693
Should fix #99 (zeros breaking lines)
...
see https://github.com/parsecsv/parsecsv-for-php/issues/99
2017-11-03 21:35:58 +01:00
Christian Bläul
b9cf7cb0c1
Improved PHPDoc blocks
...
Added missing parameters, wrapped at 80 characters, added types.
2017-11-03 20:25:56 +01:00
Christian Bläul
4bae0d2bcf
Re-added the code to grap object-level filename in output()
...
Follow-up on pull request #88 : No breaking compatibality with
older parsecsv versions.
If no output to browser is desired, set $output_filename to null,
or use unparse() function.
2017-11-03 20:23:12 +01:00
Jan Piskvor Martinec
189746405f
Do not force filename if not set explicitly
...
Per docblock, the function output() is supposed to output to browser
only if filename is passed into it.
If not, it should return the CSV as a string, not auto-set filename.
2017-11-03 11:30:55 -06:00
Marvin Feldmann
fa5aea7631
Suppress file name too long warning
...
Suppress Warning: "File name is longer than the maximum allowed path length on this platform (4096)"
2015-09-14 17:15:10 +02:00
William Knauss
4f144f2662
Addresses #62
2015-07-11 13:15:34 -04:00
William Knauss
ba4c30add1
Addresses #51
2015-07-11 13:09:20 -04:00
William Knauss
8bb51f8bab
Fixing flock issue
...
Why not make life easier just use file put contents
2015-03-25 22:19:54 -04:00
Sergio Melendez
5e8a5df988
Added iconv() to output method
2014-10-07 08:46:14 -05:00
William Knauss
2f3732e350
_wfile
2014-06-05 20:53:19 -04:00
William Knauss
01e71adf36
_rfile
2014-06-05 20:52:43 -04:00
William Knauss
0c4a804db1
_check_count
2014-06-05 20:52:23 -04:00
William Knauss
4366201dc0
_check_data
2014-06-05 20:51:26 -04:00
William Knauss
0422d5d9fe
_enclose_value
2014-06-05 20:50:48 -04:00
William Knauss
6f4d150e6f
_validate_offset
2014-06-05 20:50:08 -04:00
William Knauss
494087ab1d
_validate_row_condition
2014-06-05 20:49:49 -04:00
William Knauss
ce19deec4e
_validate_row_conditions
2014-06-05 20:48:11 -04:00
William Knauss
33825514d9
load_data
2014-06-05 20:46:29 -04:00
William Knauss
8af4d1e513
unparse
2014-06-05 20:45:28 -04:00
William Knauss
4d07760933
parse_string
2014-06-05 20:44:14 -04:00
William Knauss
710f22eeb9
parse_file
2014-06-05 20:40:00 -04:00
William Knauss
604872faad
auto
2014-06-05 20:39:21 -04:00
William Knauss
8e19ecf94f
encoding
2014-06-05 20:37:02 -04:00
William Knauss
31417caafd
output
2014-06-05 20:36:32 -04:00
William Knauss
17e060ea33
save
2014-06-05 20:35:40 -04:00
William Knauss
936b6f4a50
parse
2014-06-05 20:34:08 -04:00
William Knauss
65061046bd
__construct
2014-06-05 20:32:55 -04:00
William Knauss
8bbd474e66
Merge pull request #32 from williamknauss/proper-access
...
Proper access
2014-06-05 20:22:09 -04:00
William Knauss
734b35abc5
made _validate_row_conditions protected
2014-06-05 20:18:17 -04:00
William Knauss
5cb602be2d
made _validate_row_condition protected
2014-06-05 20:17:58 -04:00
William Knauss
b8920f99cb
made _validate_offset protected
2014-06-05 20:17:29 -04:00
William Knauss
b8248af92e
made _enclose_value protected
2014-06-05 20:17:08 -04:00
William Knauss
d1f25ee3df
made _check_data protected
2014-06-05 20:16:45 -04:00
William Knauss
0d5ae35a34
made _check_count protected
2014-06-05 20:15:20 -04:00
William Knauss
e1c8cae852
made _rfile protected
2014-06-05 20:14:50 -04:00