feat(navigation): use consult instead of helm for imenu completion

When lsp-mode is enabled, use consult-lsp-file-symbols instead of
consult-imenu, as it yields a more structured list and nicer formatted
symbol results. The result list is identical as lsp-mode updates imenu
with all file symbols, but via imenu they're just not rendered as
nicely.

core/siren-core-modules.el

@@ -84,6 +84,7 @@
 
 ;; Language Servers
 (require 'siren-lsp)
+(require 'siren-consult-lsp)
 (require 'siren-helm-lsp)
 
 ;; Debugging

modules/lsp/siren-consult-lsp.el

@@ -0,0 +1,18 @@
+;;; siren-consult-lsp.el --- jimeh's Emacs Siren: consult-lsp configuration.
+
+;;; Commentary:
+
+;; Basic configuration for consult-lsp.
+
+;;; Code:
+
+(require 'siren-consult)
+(require 'siren-lsp)
+
+(use-package consult-lsp
+  :bind
+  (:map lsp-mode-map
+        ("C-t" . consult-lsp-file-symbols)))
+
+(provide 'siren-consult-lsp)
+;;; siren-consult-lsp.el ends here

modules/navigation/siren-consult.el

@@ -9,6 +9,7 @@
 (use-package consult
   :defer t
   :bind
+  ("C-t" . consult-imenu)
   ("C-x b" . consult-buffer)
   ("M-g M-g" . consult-goto-line)
 

modules/navigation/siren-helm.el

@@ -137,11 +137,6 @@
   ("C-c f f" . helm-for-files)
   ("C-c f r" . helm-recentf))
 
-(use-package helm-imenu
-  :straight helm
-  :after (helm-global-bindings)
-  :bind
-  ("C-t" . helm-imenu))
 
 (use-package helm-ring
   :straight helm

straight/versions/default.el

@@ -15,6 +15,7 @@
  ("company-mode" . "1887974e7ad50cb4884fbec27985078bba754b60")
  ("company-nginx" . "82bdb730ad5971c594d9c99c069f3c7bb067897d")
  ("consult" . "a07ca383318cdce6935a370f1d17687ba9f225c3")
+ ("consult-lsp" . "b9aa9617f174a304040ae75d35483fa8d4ade5d7")
  ("ctrlf" . "b8a7899faf9d37f1990dfefd9c6b2998c40d7fcc")
  ("cucumber.el" . "8e1464113b489b54067294cd988ff6a11a423fdb")
  ("dap-mode" . "00e1a5d70c32019800b8eb09d2fbcecbcb727a16")