fix(navigation): remove ctrlf package in favor of isearch

Visually ctrlf is very nice, but it seems one of it's features is to
stay active in the mini-buffer until explicitly cancelled. This can
easily lead to annoyance if you mess up a C-x C-s keybind and then move
on to other buffers and such, as ctrlf will still be active.

Regular isearch however will dismiss itself as soon as you do anything
other than typing in a search query. Hence causing a lot less annoyance
for me.

core/siren-core-modules.el

@@ -65,7 +65,6 @@
 (require 'siren-avy)
 (require 'siren-centaur-tabs)
 (require 'siren-consult)
-(require 'siren-ctrlf)
 (require 'siren-dired)
 (require 'siren-dumb-jump)
 (require 'siren-git-link)
@@ -73,6 +72,7 @@
 (require 'siren-helm-ag)
 (require 'siren-helm-swoop)
 (require 'siren-imenu)
+(require 'siren-isearch)
 (require 'siren-recursive-narrow)
 (require 'siren-scroll-half-screen)
 

modules/navigation/siren-isearch.el

@@ -0,0 +1,18 @@
+;;; siren-isearch.el --- jimeh's Emacs Siren: isearch configuration.
+
+;;; Commentary:
+
+;; Basic configuration for isearch.
+
+;;; Code:
+
+(use-package isearch
+  :straight (:type built-in)
+  :custom
+  (isearch-lazy-count t)
+  (regexp-search-ring-max 200)
+  (search-default-mode t)
+  (search-ring-max 200))
+
+(provide 'siren-isearch)
+;;; siren-isearch.el ends here