Small tweak to readme

README.md

@@ -1,14 +1,20 @@
-# Airbrake-Statsd
+# Airbrake-Statsd [![Build Status](https://secure.travis-ci.org/jimeh/airbrake-statsd.png)](http://travis-ci.org/jimeh/airbrake-statsd)
 
-[![Build Status](https://secure.travis-ci.org/jimeh/airbrake-statsd.png)](http://travis-ci.org/jimeh/airbrake-statsd)
-
-Extends the [Airbrake][] gem to also report exceptions Esty's [Statsd][]
+Extends the [Airbrake][] gem to also report exceptions to Esty's [StatsD][]
 statistics aggregator.
 
 ## Installation
 
+Command line:
+
     gem install airbrake-statsd
 
+Gemfile:
+
+```ruby
+gem 'airbrake-statsd'
+```
+
 ## Usage
 
 It's assumed you know what both Airbrake and StatsD are before attempting to

lib/airbrake-statsd.rb

@@ -32,7 +32,7 @@ module Airbrake
 
       def increment
         return unless configured?
-        client.increment('exceptions')
+        client.increment(config.bucket)
       end
 
     end # << self

lib/airbrake-statsd/airbrake_ext.rb

@@ -1,21 +1,15 @@
 module Airbrake
   class << self
 
-    def notify_with_statds(*args)
+    private
+
+    def send_notice_with_statsd(*args)
       Airbrake::Statsd.increment
-      notify_without_statsd(*args)
+      send_notice_without_statsd(*args)
     end
 
-    alias :notify_without_statsd :notify
-    alias :notify :notify_with_statds
-
-    def notify_or_ignore_with_statsd(*args)
-      Airbrake::Statsd.increment
-      notify_or_ignore_without_statsd(*args)
-    end
-
-    alias :notify_or_ignore_without_statsd :notify_or_ignore
-    alias :notify_or_ignore :notify_or_ignore_with_statsd
+    alias :send_notice_without_statsd :send_notice
+    alias :send_notice :send_notice_with_statsd
 
   end
 end

lib/airbrake-statsd/configuration.rb

@@ -14,6 +14,11 @@ module Airbrake
       end
       attr_writer :port
 
+      def bucket
+        @bucket ||= 'exceptions'
+      end
+      attr_writer :bucket
+
     end # Configuration
   end # Statsd
 end # Airbrake

lib/airbrake-statsd/version.rb

@@ -1,5 +1,5 @@
 module Airbrake
   module Statsd
-    VERSION = '0.1.0'
+    VERSION = '0.2.1'
   end
 end

spec/unit/airbrake-statsd/airbrake_ext_spec.rb

@@ -4,58 +4,33 @@ describe Airbrake do
 
   subject { Airbrake }
 
-  it '#notify is an alias to #notify_with_statsd' do
-    subject.method(:notify).should == subject.method(:notify_with_statds)
+  let(:notice) { mock('Notice', :to_xml => '') }
+  let(:configuration) { mock('Configuration', :public? => true) }
+
+  let(:sender) do
+    sender = mock('Sender')
+    sender.stub(:send_to_airbrake)
+    sender
   end
 
-  it '#notify_or_ignore is an alias to #notify_or_ignore_with_statsd' do
-    subject.method(:notify_or_ignore).
-      should == subject.method(:notify_or_ignore_with_statsd)
-  end
+  describe '#send_notice_without_statsd' do
+    before do
+      Airbrake.stub(:configuration).and_return(configuration)
+      Airbrake.stub(:sender).and_return(sender)
+    end
 
-  describe '#notify_without_statsd' do
     it 'does not call Airbrake::Statsd.increment' do
-      Airbrake.stub(:send_notice).and_return(nil)
-
-      Airbrake.should_receive(:build_notice_for).with('oops', {})
       Airbrake::Statsd.should_not_receive(:increment)
-
-      Airbrake.notify_without_statsd('oops', {})
+      Airbrake.send(:send_notice_without_statsd, notice)
     end
   end
 
-  describe '#notify' do
+  describe '#send_notice' do
     it 'calls Airbrake::Statsd.increment' do
-      Airbrake.stub(:send_notice).and_return(nil)
-
-      Airbrake.should_receive(:build_notice_for).with('oops', {})
       Airbrake::Statsd.should_receive(:increment)
+      Airbrake.should_receive(:send_notice_without_statsd)
 
-      Airbrake.notify('oops', {})
-    end
-  end
-
-  describe '#notify_or_ignore_without_statsd' do
-    it 'does not call Airbrake::Statsd.increment' do
-      Airbrake.stub(:send_notice).and_return(nil)
-
-      Airbrake.should_receive(:build_notice_for).with('oops', {}).
-        and_return(mock('Notice', :ignore? => false))
-      Airbrake::Statsd.should_not_receive(:increment)
-
-      Airbrake.notify_or_ignore_without_statsd('oops', {})
-    end
-  end
-
-  describe '#notify_or_ignore' do
-    it 'calls Airbrake::Statsd.increment' do
-      Airbrake.stub(:send_notice).and_return(nil)
-
-      Airbrake.should_receive(:build_notice_for).with('oops', {}).
-        and_return(mock('Notice', :ignore? => false))
-      Airbrake::Statsd.should_receive(:increment)
-
-      Airbrake.notify_or_ignore('oops', {})
+      Airbrake.send(:send_notice, notice)
     end
   end
 

spec/unit/airbrake-statsd/configuration_spec.rb

@@ -37,6 +37,17 @@ module Airbrake
         end
       end
 
+      describe '`bucket` option' do
+        it 'defaults to "exceptions"' do
+          subject.bucket.should == 'exceptions'
+        end
+
+        it 'can be set' do
+          subject.bucket = 'errors'
+          subject.bucket.should == 'errors'
+        end
+      end
+
     end
   end
 end

spec/unit/airbrake-statsd_spec.rb

@@ -6,11 +6,26 @@ module Airbrake
     subject { Statsd }
 
     before do
-      subject.instance_variable_set('@configured', nil)
-      subject.instance_variable_set('@config', nil)
-      subject.instance_variable_set('@client', nil)
+      ['@configured', '@config', '@client'].each do |var_name|
+        subject.instance_variable_set(var_name, nil)
+      end
     end
 
+    describe '#configure' do
+      it 'sets @configured to true' do
+        subject.instance_variable_get('@configured').should_not be_true
+        subject.configure
+        subject.instance_variable_get('@configured').should be_true
+      end
+
+      context 'when block is passed' do
+        it 'passes #config to block' do
+          block = Proc.new { |conf| conf.should be_a(Statsd::Configuration) }
+          subject.configure(&block)
+        end
+      end # block passed
+    end # configure
+
     describe '#configured?' do
       context 'when #configure has been called' do
         it 'returns true' do
@@ -30,7 +45,7 @@ module Airbrake
       it 'creates new Configuration instance if not set' do
         subject.config.should be_a(Statsd::Configuration)
       end
-    end
+    end # config
 
     describe '#client' do
       it 'creates a new ::Statsd client instance if not set' do
@@ -49,23 +64,36 @@ module Airbrake
           ::Statsd.any_instance.should_receive(:namespace=).with('test').once
           subject.client
         end
-      end
-    end
+      end # namespace is set
+    end # client
 
     describe '#increment' do
       context 'when #configure has been called' do
         before { subject.configure }
 
-        it 'calls #increment on #client instance' do
-          subject.client.should_receive(:increment).once
-          subject.increment
-        end
-
-        it 'default bucket name used is "exceptions"' do
+        it 'calls #increment on #client' do
           subject.client.should_receive(:increment).with('exceptions').once
           subject.increment
         end
+
+        context 'when bucket option has been customized' do
+          before do
+            subject.configure { |config| config.bucket = 'errors' }
+          end
+
+          it 'calls #increment on #client with custom bucket' do
+            subject.client.should_receive(:increment).with('errors').once
+            subject.increment
+          end
+        end # bucket option customized
       end # configure called
+
+      context 'when #configure has not been called' do
+        it 'does not call #increment on #client' do
+          subject.client.should_not_receive(:increment)
+          subject.increment
+        end
+      end # configure not called
     end # increment
 
   end