jimeh/build-emacs-for-macos
1
0
Fork 0
mirror of https://github.com/jimeh/build-emacs-for-macos.git synced 2026-02-19 02:36:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(signing): remove entitlements which I believe caused the app to not launch

Browse Source
This commit is contained in:
Jim Myhrberg
2021-11-28 13:43:34 +00:00
parent 1be824cc49
commit 876388f686
2 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/sign/entitlements.go
View File

@@ -17,12 +17,8 @@ var DefaultEmacsEntitlements = []string{
"com.apple.security.cs.allow-dyld-environment-variables",
"com.apple.security.cs.allow-jit",
"com.apple.security.cs.disable-library-validation",
"com.apple.security.device.audio-input",
"com.apple.security.device.camera",
"com.apple.security.device.microphone",
"com.apple.security.network.client",
"com.apple.security.network.server",
"com.apple.security.print",
}
//go:embed entitlements.tpl

36
pkg/sign/entitlements_test.go
View File

@@ -47,11 +47,14 @@ var entitlementsTestCases = []struct {
{
name: "many",
entitlements: Entitlements{
"com.apple.security.cs.allow-jit",
"com.apple.security.network.client",
"com.apple.security.cs.disable-library-validation",
"com.apple.security.cs.allow-dyld-environment-variables",
"com.apple.developer.mail-client",
"com.apple.developer.web-browser",
"com.apple.security.automation.apple-events",
"com.apple.security.cs.allow-dyld-environment-variables",
"com.apple.security.cs.allow-jit",
"com.apple.security.cs.disable-library-validation",
"com.apple.security.network.client",
"com.apple.security.network.server",
},
//nolint:lll
want: undent.String(`
@@ -59,15 +62,21 @@ var entitlementsTestCases = []struct {
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.security.cs.allow-jit</key>
<key>com.apple.developer.mail-client</key>
<true/>
<key>com.apple.security.network.client</key>
<key>com.apple.developer.web-browser</key>
<true/>
<key>com.apple.security.cs.disable-library-validation</key>
<key>com.apple.security.automation.apple-events</key>
<true/>
<key>com.apple.security.cs.allow-dyld-environment-variables</key>
<true/>
<key>com.apple.security.automation.apple-events</key>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.disable-library-validation</key>
<true/>
<key>com.apple.security.network.client</key>
<true/>
<key>com.apple.security.network.server</key>
<true/>
</dict>
</plist>`,
@@ -78,11 +87,14 @@ var entitlementsTestCases = []struct {
func TestDefaultEmacsEntitlements(t *testing.T) {
assert.Equal(t,
[]string{
"com.apple.security.cs.allow-jit",
"com.apple.security.network.client",
"com.apple.security.cs.disable-library-validation",
"com.apple.security.cs.allow-dyld-environment-variables",
"com.apple.developer.mail-client",
"com.apple.developer.web-browser",
"com.apple.security.automation.apple-events",
"com.apple.security.cs.allow-dyld-environment-variables",
"com.apple.security.cs.allow-jit",
"com.apple.security.cs.disable-library-validation",
"com.apple.security.network.client",
"com.apple.security.network.server",
},
DefaultEmacsEntitlements,
)