chore(release): 0.4.9

fix(cli): default to "master" if no git ref is given
Fixes #35
2026-02-19 13:06:38 +00:00 · 2021-04-08 12:03:41 +01:00 · 2021-04-08 12:02:45 +01:00 · 2021-04-08 11:54:01 +01:00
2 changed files with 19 additions and 3 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,14 @@

 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

+### [0.4.9](https://github.com/jimeh/build-emacs-for-macos/compare/0.4.8...0.4.9) (2021-04-08)
+
+
+### Bug Fixes
+
+* **cli:** default to "master" if no git ref is given ([e19a6a7](https://github.com/jimeh/build-emacs-for-macos/commit/e19a6a7bc24379292ee06ae4c805b8c5365f2d97)), closes [#35](https://github.com/jimeh/build-emacs-for-macos/issues/35)
+* **native_comp:** skip symlink creation for recent builds which do not need symlinks ([1000999](https://github.com/jimeh/build-emacs-for-macos/commit/1000999eb2673dc207a390ff3f902b9987b99173))
+
 ### [0.4.8](https://github.com/jimeh/build-emacs-for-macos/compare/0.4.7...0.4.8) (2021-02-27)


--- a/14
+++ b/14
@@ -339,13 +339,20 @@ class Build
  def symlink_internals(app)
    return unless options[:native_comp]

-    info 'Creating symlinks within Emacs.app needed for native-comp'
-
    FileUtils.cd(File.join(app, 'Contents')) do
+      # Skip creation of symlinks if *.eln files are located under
+      # Resources/native-lisp. Emacs is capable of finding lisp sources and
+      # *.eln cache files without symlinks.
+      return if Dir['Resources/native-lisp/**/*.eln'].any?
+
+      info 'Creating symlinks within Emacs.app needed for native-comp'
+
      FileUtils.ln_s('Resources/lisp', 'lisp') unless File.exist?('lisp')

      source = Dir['MacOS/libexec/emacs/**/eln-cache',
                   'MacOS/lib/emacs/**/native-lisp'].first
+      err 'Failed to find native-lisp cache directory for symlink creation.'
+
      target = File.basename(source)
      FileUtils.ln_s(source, target) unless File.exist?(target)
    end
@@ -395,7 +402,8 @@ class Build
  def meta
    return @meta if @meta

-    ref_sha = options[:git_sha] || ref
+    ref_sha = options[:git_sha] || ref || 'master'
+    info "Fetching info for git ref: #{ref_sha}"
    url = format(LATEST_URL, ref_sha)
    commit_json = http_get(url)
    err "Failed to get commit info about: #{ref_sha}" if commit_json.nil?
Author	SHA1	Message	Date
Jim Myhrberg	f1fc68c8f5	chore(release): 0.4.9	2021-04-08 12:03:41 +01:00
Jim Myhrberg	e19a6a7bc2	fix(cli): default to "master" if no git ref is given Fixes #35	2021-04-08 12:02:45 +01:00
Jim Myhrberg	1000999eb2	fix(native_comp): skip symlink creation for recent builds which do not need symlinks Recent builds places the native-lisp cache folder within Contents/Resources on macOS, and correctly deals with finding them. This means the Contents/lisp and Contents/native-lisp symlinks are no longer needed. Hence we skip their creation altogether if we find any Contents/Resources/native-lisp/*/.eln files.	2021-04-08 11:54:01 +01:00