mirror of
https://github.com/jimeh/build-emacs-for-macos.git
synced 2026-02-19 13:06:38 +00:00
Compare commits
12 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
2320030121 | ||
| c53c398cac | |||
|
|
f7b2baa363 | ||
|
d396165808
|
|||
| 66ccd9c6fd | |||
|
|
907f7babbc | ||
|
e030fee670
|
|||
|
|
0ea0596f69 | ||
| 03ed54ca78 | |||
|
|
9d98b6340b | ||
|
cbac633efb
|
|||
|
db723817bf
|
2
.github/.release-please-manifest.json
vendored
2
.github/.release-please-manifest.json
vendored
@@ -1,3 +1,3 @@
|
||||
{
|
||||
".": "0.6.52"
|
||||
".": "0.6.57"
|
||||
}
|
||||
|
||||
40
CHANGELOG.md
40
CHANGELOG.md
@@ -1,5 +1,45 @@
|
||||
# Changelog
|
||||
|
||||
## [0.6.57](https://github.com/jimeh/build-emacs-for-macos/compare/v0.6.56...v0.6.57) (2024-12-07)
|
||||
|
||||
|
||||
### Features
|
||||
|
||||
* **patches/alpha-background:** add experimental alpha-background patch ([#129](https://github.com/jimeh/build-emacs-for-macos/issues/129)) ([c53c398](https://github.com/jimeh/build-emacs-for-macos/commit/c53c398cace6479a9c188e46196462791960abee)), closes [#111](https://github.com/jimeh/build-emacs-for-macos/issues/111)
|
||||
|
||||
## [0.6.56](https://github.com/jimeh/build-emacs-for-macos/compare/v0.6.55...v0.6.56) (2024-12-03)
|
||||
|
||||
|
||||
### Features
|
||||
|
||||
* **options:** add --patch option which accepts file path or URL ([#127](https://github.com/jimeh/build-emacs-for-macos/issues/127)) ([66ccd9c](https://github.com/jimeh/build-emacs-for-macos/commit/66ccd9c6fd077d558eae484cdbab831486fbfd58))
|
||||
|
||||
|
||||
### Bug Fixes
|
||||
|
||||
* **patches:** improve chance of successful patch application by using -l ([d396165](https://github.com/jimeh/build-emacs-for-macos/commit/d396165808ab5852566e7ff6bcc23d47ddfdfdee))
|
||||
|
||||
## [0.6.55](https://github.com/jimeh/build-emacs-for-macos/compare/v0.6.54...v0.6.55) (2024-12-03)
|
||||
|
||||
|
||||
### Features
|
||||
|
||||
* **nix/deps:** update nixpkgs from 24.11-beta to 24.11 ([e030fee](https://github.com/jimeh/build-emacs-for-macos/commit/e030fee6704618b7ddefea7424dff4e94f43e84d))
|
||||
|
||||
## [0.6.54](https://github.com/jimeh/build-emacs-for-macos/compare/v0.6.53...v0.6.54) (2024-12-01)
|
||||
|
||||
|
||||
### Features
|
||||
|
||||
* **startup:** replace bundled site-start.el approach with a custom source patch ([#124](https://github.com/jimeh/build-emacs-for-macos/issues/124)) ([03ed54c](https://github.com/jimeh/build-emacs-for-macos/commit/03ed54ca78ce15b61f5c875f97410b3ff21ecd62))
|
||||
|
||||
## [0.6.53](https://github.com/jimeh/build-emacs-for-macos/compare/v0.6.52...v0.6.53) (2024-12-01)
|
||||
|
||||
|
||||
### Bug Fixes
|
||||
|
||||
* **help:** correct formatting of help text output ([db72381](https://github.com/jimeh/build-emacs-for-macos/commit/db723817bf6c0ac85da1790a1d50fbea774cc0c0))
|
||||
|
||||
## [0.6.52](https://github.com/jimeh/build-emacs-for-macos/compare/v0.6.51...v0.6.52) (2024-11-30)
|
||||
|
||||
|
||||
|
||||
43
README.md
43
README.md
@@ -73,23 +73,26 @@ make bootstrap
|
||||
|
||||
## Status
|
||||
|
||||
As of writing (2023-11-20) it works for me on my machine and for the nightly
|
||||
As of writing (2024-11-30) it works for me on my machine and for the nightly
|
||||
builds in [jimeh/emacs-builds](https://github.com/jimeh/emacs-builds). Your luck
|
||||
may vary.
|
||||
|
||||
I have successfully built:
|
||||
|
||||
- `emacs-29.1` release tag.
|
||||
- `master` branch (Emacs 30.x).
|
||||
- `emacs-29.4` release tag.
|
||||
- `emacs-30.0.92` pretest tag.
|
||||
- `master` branch (Emacs 31.x).
|
||||
|
||||
For reference, my machine is:
|
||||
|
||||
- 14-inch MacBook Pro (2023), Apple M3 Pro (11-cores)
|
||||
- macOS Sonoma 14.1.1 (23B2082)
|
||||
- Xcode 15.0.1 (15A507)
|
||||
- 14-inch MacBook Pro (2023), Apple M3 Max (16-cores)
|
||||
- macOS Sonoma 15.1.1 (24B91)
|
||||
- Xcode 16.1 (16B40)
|
||||
|
||||
Nightly builds are built with GitHub Actions on GitHub-hosted runners, using
|
||||
`macos-12` for Intel builds, and `macos-13-xlarge` for Apple Silicon builds.
|
||||
The [nightly builds](https://github.com/jimeh/emacs-builds) are built with
|
||||
GitHub Actions on GitHub-hosted runners, using `macos-13` for Intel builds, and
|
||||
`macos-14` for Apple Silicon builds. The build environment is managed with Nix,
|
||||
and targets the macOS 11 SDK.
|
||||
|
||||
## Usage
|
||||
|
||||
@@ -105,6 +108,11 @@ Or you can run the build script via `nix develop`:
|
||||
nix develop --command ./build-emacs-for-macos --help
|
||||
```
|
||||
|
||||
The Nix environment defaults to targeting the macOS 11 SDK, which makes Emacs
|
||||
builds compatible with macOS 11.3 or later. You can easily target later macOS
|
||||
SDKs. Versions 11 to 15 are available. For example, to target the macOS 12 SDK,
|
||||
run `nix develop .#macos12`
|
||||
|
||||
### Homebrew
|
||||
|
||||
Run `make boostrap` to ensure all Ruby and Homebrew dependencies are installed.
|
||||
@@ -123,18 +131,23 @@ Options:
|
||||
-j, --parallel COUNT Compile using COUNT parallel processes (detected: 16)
|
||||
--git-sha SHA Override detected git SHA of specified branch allowing builds of old commits
|
||||
--[no-]use-nix Use Nix instead of Homebrew to find dependencies (default: enabled if IN_NIX_SHELL is set)
|
||||
--[no-]xwidgets Enable/disable XWidgets if supported (default: enabled)
|
||||
--[no-]tree-sitter Enable/disable tree-sitter if supported (default: enabled)
|
||||
--[no-]native-comp Enable/disable native-comp (default: enabled if supported)
|
||||
--[no-]native-march Enable/disable -march=native CFLAG(default: disabled)
|
||||
--optimize Shorthand for --native-march --native-mtune --fomit-frame-pointer (default: disabled)
|
||||
--[no-]native-march Enable/disable -march=native CFLAG (default: disabled)
|
||||
--[no-]native-mtune Enable/disable -mtune=native CFLAG (default: disabled)
|
||||
--[no-]fomit-frame-pointer Enable/disable -fomit-frame-pointer CFLAG (default: disabled)
|
||||
--[no-]native-full-aot Enable/disable NATIVE_FULL_AOT / Ahead of Time compilation (default: disabled)
|
||||
--[no-]relink-eln-files Enable/disable re-linking shared libraries in bundled *.eln files (default: enabled)
|
||||
--[no-]rsvg Enable/disable SVG image support via librsvg (default: enabled)
|
||||
--[no-]dbus Enable/disable dbus support (default: enabled)
|
||||
--no-titlebar Apply no-titlebar patch (default: disabled)
|
||||
--posix-spawn Apply posix-spawn patch (deprecated)
|
||||
--no-frame-refocus Apply no-frame-refocus patch (default: disabled)
|
||||
--[no-]alpha-background Enable/disable experimental alpha-background patch when building Emacs 30.x - 31.x (default: disabled)
|
||||
--no-frame-refocus Apply no-frame-refocus patch when building Emacs 27.x - 31.x (default: disabled)
|
||||
--no-titlebar Apply no-titlebar patch when building Emacs 27.x - 28.x (default: disabled)
|
||||
--[no-]xwidgets Enable/disable XWidgets when building Emacs 27.x (default: disabled)
|
||||
--[no-]poll Apply poll patch (deprecated)
|
||||
--posix-spawn Apply posix-spawn patch (deprecated)
|
||||
-p, --patch=URL Specify a custom patch file or URL to apply to the Emacs source (can be used multiple times)
|
||||
--[no-]fd-setsize SIZE Set an file descriptor (max open files) limit (default: 10000)
|
||||
--github-src-repo REPO Specify a GitHub repo to download source tarballs from (default: emacs-mirror/emacs)
|
||||
--[no-]github-auth Make authenticated GitHub API requests if GITHUB_TOKEN environment variable is set.(default: enabled)
|
||||
@@ -168,10 +181,10 @@ as of writing) and build Emacs.app from it:
|
||||
./build-emacs-for-macos
|
||||
```
|
||||
|
||||
To build the stable `emacs-29.1` release git tag run:
|
||||
To build the stable `emacs-29.4` release git tag run:
|
||||
|
||||
```
|
||||
./build-emacs-for-macos emacs-29.1
|
||||
./build-emacs-for-macos emacs-29.4
|
||||
```
|
||||
|
||||
All sources as downloaded as tarballs from the
|
||||
|
||||
@@ -79,6 +79,16 @@ module Output
|
||||
end
|
||||
end
|
||||
|
||||
module Helpers
|
||||
def valid_url?(uri)
|
||||
uri = URI.parse(uri)
|
||||
(uri.is_a?(URI::HTTP) || uri.is_a?(URI::HTTPS)) &&
|
||||
uri.host.respond_to?(:empty?) && !uri.host.empty?
|
||||
rescue URI::InvalidURIError
|
||||
false
|
||||
end
|
||||
end
|
||||
|
||||
module System
|
||||
include Output
|
||||
|
||||
@@ -183,6 +193,7 @@ end
|
||||
class Build
|
||||
include Output
|
||||
include System
|
||||
include Helpers
|
||||
|
||||
DEFAULT_GITHUB_REPO = 'emacs-mirror/emacs'
|
||||
|
||||
@@ -207,7 +218,7 @@ class Build
|
||||
end
|
||||
|
||||
tarball = download_tarball(meta[:sha])
|
||||
@source_dir = extract_tarball(tarball, patches(options))
|
||||
@source_dir = extract_tarball(tarball, build_patches)
|
||||
|
||||
autogen
|
||||
detect_native_comp if options[:native_comp].nil?
|
||||
@@ -408,6 +419,7 @@ class Build
|
||||
fatal 'Tarball extraction failed.' unless result
|
||||
|
||||
patches.each { |patch| apply_patch(patch, target) }
|
||||
apply_macos_startup_patch(target)
|
||||
|
||||
# Keep a copy of src after patches have been applied. This will be used to
|
||||
# embed C sources into the output Emacs.app bundle.
|
||||
@@ -900,6 +912,93 @@ class Build
|
||||
File.write(filename, content)
|
||||
end
|
||||
|
||||
MACOS_STARTUP_EL_CONTENT = <<~ELISP
|
||||
;;; macos-startup.el --- macOS specific startup actions -*- lexical-binding: t -*-
|
||||
|
||||
;; Maintainer: Jim Myhrberg <contact@jimeh.me>
|
||||
;; Keywords: macos, internal
|
||||
;; Homepage: https://github.com/jimeh/build-emacs-for-macos
|
||||
|
||||
;; This file is not part of GNU Emacs.
|
||||
|
||||
;;; Commentary:
|
||||
|
||||
;; This file contains macOS specific startup actions for self-contained
|
||||
;; macOS *.app bundles. It enables native-compilation via a bundled
|
||||
;; libgccjit, and for bundled C-sources to be found for documentation
|
||||
;; purposes,
|
||||
|
||||
;;; Code:
|
||||
|
||||
(defun macos-startup--in-app-bundle-p ()
|
||||
"Check if invoked from a macOS .app bundle."
|
||||
(and (eq system-type 'darwin)
|
||||
invocation-directory
|
||||
(string-match-p ".+\\.app/Contents/MacOS/?$" invocation-directory)))
|
||||
|
||||
(defun macos-startup--set-source-directory ()
|
||||
"Set `source-directory' so that C-sources can be located."
|
||||
(let* ((src-dir (expand-file-name "../Resources/src" invocation-directory)))
|
||||
(when (file-directory-p src-dir)
|
||||
(setq source-directory (file-name-directory src-dir)))))
|
||||
|
||||
(defun macos-startup--setup-library-path ()
|
||||
"Configure LIBRARY_PATH env var for native compilation on macOS.
|
||||
|
||||
Ensures LIBRARY_PATH includes paths to the libgccjit and gcc libraries
|
||||
which are bundled into the .app bundle. This allows native compilation
|
||||
to work without any external system dependencies aside from Xcode."
|
||||
(let* ((new-paths
|
||||
(list (expand-file-name "../Frameworks/gcc/lib" invocation-directory)
|
||||
(expand-file-name "../Frameworks/gcc/lib/apple-darwin" invocation-directory)
|
||||
"/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib"))
|
||||
(valid-paths (delq nil (mapcar (lambda (path)
|
||||
(when (file-directory-p path)
|
||||
path))
|
||||
new-paths)))
|
||||
(existing-paths (split-string (or (getenv "LIBRARY_PATH") "") ":" t))
|
||||
(unique-paths (delete-dups (append valid-paths existing-paths))))
|
||||
|
||||
(when unique-paths
|
||||
(setenv "LIBRARY_PATH" (mapconcat 'identity unique-paths path-separator)))))
|
||||
|
||||
(defun macos-startup--init ()
|
||||
"Perform macOS specific startup operations."
|
||||
(when (macos-startup--in-app-bundle-p)
|
||||
(macos-startup--set-source-directory)
|
||||
(when (and (fboundp 'native-comp-available-p)
|
||||
(native-comp-available-p))
|
||||
(macos-startup--setup-library-path))))
|
||||
|
||||
(add-hook 'after-pdump-load-hook #'macos-startup--init)
|
||||
|
||||
;;; macos-startup.el ends here
|
||||
ELISP
|
||||
|
||||
def apply_macos_startup_patch(target)
|
||||
macos_startup_el = File.join(target, 'lisp', 'macos-startup.el')
|
||||
|
||||
unless File.exist?(macos_startup_el)
|
||||
info 'Adding macos-startup.el to lisp sources...'
|
||||
FileUtils.mkdir_p(File.dirname(macos_startup_el))
|
||||
File.write(macos_startup_el, MACOS_STARTUP_EL_CONTENT)
|
||||
end
|
||||
|
||||
loadup_el = File.join(target, 'lisp', 'loadup.el')
|
||||
loadup_content = File.read(loadup_el)
|
||||
|
||||
return if loadup_content.include?('(load "macos-startup")')
|
||||
|
||||
info 'Patching loadup.el to load macos-startup.el...'
|
||||
File.write(
|
||||
loadup_el,
|
||||
loadup_content.gsub(
|
||||
'(load "startup")',
|
||||
"(load \"startup\")\n(load \"macos-startup\")"
|
||||
)
|
||||
)
|
||||
end
|
||||
|
||||
def meta
|
||||
return @meta if @meta
|
||||
|
||||
@@ -953,7 +1052,7 @@ class Build
|
||||
end
|
||||
end
|
||||
|
||||
def patches(opts = {})
|
||||
def build_patches
|
||||
p = []
|
||||
|
||||
# Enabled by default patches.
|
||||
@@ -1030,7 +1129,7 @@ class Build
|
||||
}
|
||||
end
|
||||
|
||||
if opts[:xwidgets] && effective_version == 27
|
||||
if options[:xwidgets] && effective_version == 27
|
||||
p << {
|
||||
url:
|
||||
'https://github.com/d12frosted/homebrew-emacs-plus/raw/master/' \
|
||||
@@ -1038,6 +1137,36 @@ class Build
|
||||
}
|
||||
end
|
||||
|
||||
if options[:alpha_background]
|
||||
if effective_version == 29
|
||||
p << {
|
||||
file: File.join(
|
||||
__dir__, 'patches', 'emacs-29', 'ns-alpha-background.patch'
|
||||
)
|
||||
}
|
||||
elsif (30..31).include?(effective_version)
|
||||
p << {
|
||||
url:
|
||||
"https://github.com/emacs-mirror/emacs/compare/#{meta[:sha]}" \
|
||||
'...jonrubens:emacs:ns-alpha-background.patch'
|
||||
}
|
||||
end
|
||||
end
|
||||
|
||||
# Custom patches.
|
||||
options[:patches].each do |patch_str|
|
||||
patch = {}
|
||||
if valid_url?(patch_str)
|
||||
patch[:url] = patch_str
|
||||
elsif File.exist?(patch_str)
|
||||
patch[:file] = patch_str
|
||||
else
|
||||
fatal "Patch file or URL not found: #{patch_str}"
|
||||
end
|
||||
|
||||
p << patch
|
||||
end
|
||||
|
||||
p.uniq
|
||||
end
|
||||
|
||||
@@ -1046,7 +1175,9 @@ class Build
|
||||
|
||||
if patch[:file]
|
||||
info 'Applying patch...'
|
||||
FileUtils.cd(target) { run_cmd('patch', '-f', '-p1', '-i', patch[:file]) }
|
||||
FileUtils.cd(target) do
|
||||
run_cmd('patch', '-f', '-p1', '-l', '-i', patch[:file])
|
||||
end
|
||||
elsif patch[:url]
|
||||
patch_dir = "#{target}/macos_patches"
|
||||
run_cmd('mkdir', '-p', patch_dir)
|
||||
@@ -1068,6 +1199,20 @@ class Build
|
||||
else
|
||||
apply_patch({ file: patch_file }, target)
|
||||
end
|
||||
elsif patch[:source]
|
||||
patch_dir = "#{target}/macos_patches"
|
||||
run_cmd('mkdir', '-p', patch_dir)
|
||||
|
||||
patch_file = File.join(patch_dir, 'patch-{num}.diff')
|
||||
num = 1
|
||||
while File.exist?(patch_file.gsub('{num}', num.to_s.rjust(3, '0')))
|
||||
num += 1
|
||||
end
|
||||
patch_file = patch_file.gsub('{num}', num.to_s.rjust(3, '0'))
|
||||
|
||||
File.write(patch_file, patch[:source])
|
||||
|
||||
apply_patch({ file: patch_file }, target)
|
||||
elsif patch[:replace]
|
||||
fatal 'Patch replace input error' unless patch[:replace].size == 3
|
||||
|
||||
@@ -1198,12 +1343,6 @@ class CLIHelperEmbedder < AbstractEmbedder
|
||||
end
|
||||
|
||||
class CSourcesEmbedder < AbstractEmbedder
|
||||
PATH_PATCH = <<~ELISP
|
||||
;; Allow Emacs to find bundled C sources.
|
||||
(setq source-directory
|
||||
(expand-file-name ".." (file-name-directory load-file-name)))
|
||||
ELISP
|
||||
|
||||
attr_reader :source_dir
|
||||
|
||||
def initialize(app, source_dir)
|
||||
@@ -1228,15 +1367,6 @@ class CSourcesEmbedder < AbstractEmbedder
|
||||
src_dir, target_dir, File.join('**', '*.{awk,c,cc,h,in,m,mk}')
|
||||
)
|
||||
end
|
||||
|
||||
if File.exist?(site_start_el_file) &&
|
||||
File.read(site_start_el_file).include?(PATH_PATCH)
|
||||
return
|
||||
end
|
||||
|
||||
debug "Patching '#{relative_app_path(site_start_el_file)}' to allow " \
|
||||
'Emacs to find bundled C sources'
|
||||
File.open(site_start_el_file, 'a') { |f| f.puts("\n#{PATH_PATCH}") }
|
||||
end
|
||||
|
||||
private
|
||||
@@ -1252,10 +1382,6 @@ class CSourcesEmbedder < AbstractEmbedder
|
||||
run_cmd('cp', '-pRL', f, target)
|
||||
end
|
||||
end
|
||||
|
||||
def site_start_el_file
|
||||
@site_start_el_file ||= File.join(resources_dir, 'lisp', 'site-start.el')
|
||||
end
|
||||
end
|
||||
|
||||
class LibEmbedder < AbstractEmbedder
|
||||
@@ -1521,49 +1647,13 @@ class GccLibEmbedder < AbstractEmbedder
|
||||
|
||||
FileUtils.rm(Dir[File.join(target_dir, '**', '.DS_Store')], force: true)
|
||||
|
||||
if target_darwin_dir != sanitized_target_darwin_dir
|
||||
run_cmd('mv', target_darwin_dir, sanitized_target_darwin_dir)
|
||||
end
|
||||
return unless target_darwin_dir != sanitized_target_darwin_dir
|
||||
|
||||
env_setup = ERB.new(NATIVE_COMP_ENV_VAR_TPL).result(gcc_info.get_binding)
|
||||
if File.exist?(site_start_el_file) &&
|
||||
File.read(site_start_el_file).include?(env_setup)
|
||||
return
|
||||
end
|
||||
|
||||
debug 'Setting up site-start.el for self-contained native-comp Emacs.app'
|
||||
File.open(site_start_el_file, 'a') { |f| f.puts("\n#{env_setup}") }
|
||||
run_cmd('mv', target_darwin_dir, sanitized_target_darwin_dir)
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
NATIVE_COMP_ENV_VAR_TPL = <<~ELISP
|
||||
;; Set LIBRARY_PATH to point at bundled GCC and Xcode Command Line Tools to
|
||||
;; ensure native-comp works.
|
||||
(when (and (eq system-type 'darwin)
|
||||
(string-match-p "\\.app\\/Contents\\/MacOS\\/?$"
|
||||
invocation-directory))
|
||||
(let* ((library-path-env (getenv "LIBRARY_PATH"))
|
||||
(devtools-dir
|
||||
"/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib")
|
||||
(gcc-dir (expand-file-name
|
||||
"<%= app_bundle_target_lib_dir %>"
|
||||
invocation-directory))
|
||||
(darwin-dir (expand-file-name
|
||||
"<%= app_bundle_target_darwin_lib_dir %>"
|
||||
invocation-directory))
|
||||
(lib-paths (list)))
|
||||
|
||||
(if library-path-env
|
||||
(push library-path-env lib-paths))
|
||||
(if (file-directory-p devtools-dir)
|
||||
(push devtools-dir lib-paths))
|
||||
(push darwin-dir lib-paths)
|
||||
(push gcc-dir lib-paths)
|
||||
|
||||
(setenv "LIBRARY_PATH" (mapconcat 'identity lib-paths ":"))))
|
||||
ELISP
|
||||
|
||||
# Remove all rpaths from Mach-O library files except for @loader_path.
|
||||
def tidy_lib_rpaths(directory)
|
||||
Dir[File.join(directory, '**', '*.{dylib,so}')].each do |file_path|
|
||||
@@ -1607,10 +1697,6 @@ class GccLibEmbedder < AbstractEmbedder
|
||||
def source_darwin_dir
|
||||
gcc_info.darwin_lib_dir
|
||||
end
|
||||
|
||||
def site_start_el_file
|
||||
@site_start_el_file ||= File.join(resources_dir, 'lisp', 'site-start.el')
|
||||
end
|
||||
end
|
||||
|
||||
class GccInfo
|
||||
@@ -1784,228 +1870,273 @@ class GccInfo
|
||||
end
|
||||
end
|
||||
|
||||
if __FILE__ == $PROGRAM_NAME
|
||||
use_nix_default = !ENV.fetch('IN_NIX_SHELL', '').empty?
|
||||
class CLIOptions
|
||||
include Output
|
||||
include Helpers
|
||||
|
||||
cli_options = {
|
||||
work_dir: File.expand_path(__dir__),
|
||||
native_full_aot: false,
|
||||
relink_eln: true,
|
||||
native_march: false,
|
||||
parallel: Etc.nprocessors,
|
||||
rsvg: true,
|
||||
dbus: true,
|
||||
use_nix: use_nix_default,
|
||||
xwidgets: true,
|
||||
tree_sitter: true,
|
||||
fd_setsize: 10_000,
|
||||
github_src_repo: nil,
|
||||
github_auth: true,
|
||||
dist_include: ['COPYING', 'configure_output.txt'],
|
||||
self_sign: true,
|
||||
archive: true,
|
||||
archive_keep: false,
|
||||
log_level: 'info'
|
||||
}
|
||||
|
||||
parser = OptionParser.new do |opts|
|
||||
opts.banner = <<~DOC
|
||||
Usage: ./build-emacs-for-macos [options] <branch/tag/sha>
|
||||
|
||||
Branch, tag, and SHA are from the emacs-mirror/emacs/emacs Github repo,
|
||||
available here: https://github.com/emacs-mirror/emacs
|
||||
|
||||
Options:
|
||||
DOC
|
||||
|
||||
opts.on(
|
||||
'--info',
|
||||
'Print environment info and detected library paths, then exit'
|
||||
) { |v| cli_options[:info] = v }
|
||||
|
||||
opts.on(
|
||||
'--preview',
|
||||
'Print preview details about build and exit.'
|
||||
) { |v| cli_options[:preview] = v }
|
||||
|
||||
opts.on(
|
||||
'-j',
|
||||
'--parallel COUNT',
|
||||
'Compile using COUNT parallel processes ' \
|
||||
"(detected: #{cli_options[:parallel]})"
|
||||
) { |v| cli_options[:parallel] = v }
|
||||
|
||||
opts.on(
|
||||
'--git-sha SHA',
|
||||
'Override detected git SHA of specified ' \
|
||||
'branch allowing builds of old commits'
|
||||
) { |v| cli_options[:git_sha] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]use-nix',
|
||||
'Use Nix instead of Homebrew to find dependencies ' \
|
||||
'(default: enabled if IN_NIX_SHELL is set)'
|
||||
) { |v| cli_options[:use_nix] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]xwidgets',
|
||||
'Enable/disable XWidgets if supported ' \
|
||||
'(default: enabled)'
|
||||
) { |v| cli_options[:xwidgets] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]tree-sitter',
|
||||
'Enable/disable tree-sitter if supported ' \
|
||||
'(default: enabled)'
|
||||
) { |v| cli_options[:tree_sitter] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]native-comp',
|
||||
'Enable/disable native-comp ' \
|
||||
'(default: enabled if supported)'
|
||||
) { |v| cli_options[:native_comp] = v }
|
||||
|
||||
opts.on(
|
||||
'--optimize',
|
||||
'Shorthand for --native-march --native-mtune --fomit-frame-pointer' \
|
||||
'(default: disabled)'
|
||||
) do
|
||||
cli_options[:native_march] = true
|
||||
cli_options[:native_mtune] = true
|
||||
cli_options[:fomit_frame_pointer] = true
|
||||
end
|
||||
|
||||
opts.on(
|
||||
'--[no-]native-march',
|
||||
'Enable/disable -march=native CFLAG' \
|
||||
'(default: disabled)'
|
||||
) { |v| cli_options[:native_march] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]native-mtune',
|
||||
'Enable/disable -mtune=native CFLAG' \
|
||||
'(default: disabled)'
|
||||
) { |v| cli_options[:native_mtune] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]fomit-frame-pointer',
|
||||
'Enable/disable -fomit-frame-pointer CFLAG' \
|
||||
'(default: disabled)'
|
||||
) { |v| cli_options[:fomit_frame_pointer] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]native-full-aot',
|
||||
'Enable/disable NATIVE_FULL_AOT / Ahead of Time compilation ' \
|
||||
'(default: disabled)'
|
||||
) { |v| cli_options[:native_full_aot] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]relink-eln-files',
|
||||
'Enable/disable re-linking shared libraries in bundled *.eln ' \
|
||||
'files (default: enabled)'
|
||||
) { |v| cli_options[:relink_eln] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]rsvg',
|
||||
'Enable/disable SVG image support via librsvg ' \
|
||||
'(default: enabled)'
|
||||
) { |v| cli_options[:rsvg] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]dbus',
|
||||
'Enable/disable dbus support (default: enabled)'
|
||||
) { |v| cli_options[:dbus] = v }
|
||||
|
||||
opts.on(
|
||||
'--no-titlebar',
|
||||
'Apply no-titlebar patch (default: disabled)'
|
||||
) { cli_options[:no_titlebar] = true }
|
||||
|
||||
opts.on('--posix-spawn', 'Apply posix-spawn patch (deprecated)') do
|
||||
warn '==> WARN: posix-spawn patch is deprecated and has no effect.'
|
||||
end
|
||||
|
||||
opts.on(
|
||||
'--no-frame-refocus',
|
||||
'Apply no-frame-refocus patch (default: disabled)'
|
||||
) { cli_options[:no_frame_refocus] = true }
|
||||
|
||||
opts.on('--[no-]poll', 'Apply poll patch (deprecated)') do
|
||||
warn '==> WARN: poll patch is deprecated and has no effect.'
|
||||
end
|
||||
|
||||
opts.on(
|
||||
'--[no-]fd-setsize SIZE',
|
||||
'Set an file descriptor (max open files) limit (default: 10000)'
|
||||
) { |v| cli_options[:fd_setsize] = v.respond_to?(:to_i) ? v.to_i : 0 }
|
||||
|
||||
opts.on(
|
||||
'--github-src-repo REPO',
|
||||
'Specify a GitHub repo to download source tarballs from ' \
|
||||
'(default: emacs-mirror/emacs)'
|
||||
) { |v| cli_options[:github_src_repo] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]github-auth',
|
||||
'Make authenticated GitHub API requests if GITHUB_TOKEN ' \
|
||||
'environment variable is set.' \
|
||||
'(default: enabled)'
|
||||
) { |v| cli_options[:github_auth] = v }
|
||||
|
||||
opts.on(
|
||||
'--work-dir DIR',
|
||||
'Specify a working directory where tarballs, sources, and ' \
|
||||
'builds will be stored and worked with'
|
||||
) { |v| cli_options[:work_dir] = v }
|
||||
|
||||
opts.on(
|
||||
'-o DIR',
|
||||
'--output DIR',
|
||||
'Output directory for finished builds ' \
|
||||
'(default: <work-dir>/builds)'
|
||||
) { |v| cli_options[:output] = v }
|
||||
|
||||
opts.on('--build-name NAME', 'Override generated build name') do |v|
|
||||
cli_options[:build_name] = v
|
||||
end
|
||||
|
||||
opts.on(
|
||||
'--dist-include x,y,z',
|
||||
'List of extra files to copy from Emacs source into build ' \
|
||||
'folder/archive (default: COPYING)'
|
||||
) { |v| cli_options[:dist_include] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]self-sign',
|
||||
'Enable/disable self-signing of Emacs.app (default: enabled)'
|
||||
) { |v| cli_options[:self_sign] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]archive',
|
||||
'Enable/disable creating *.tbz archive (default: enabled)'
|
||||
) { |v| cli_options[:archive] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]archive-keep-build-dir',
|
||||
'Enable/disable keeping source folder for archive ' \
|
||||
'(default: disabled)'
|
||||
) { |v| cli_options[:archive_keep] = v }
|
||||
|
||||
opts.on(
|
||||
'--log-level LEVEL',
|
||||
'Build script log level (default: info)'
|
||||
) { |v| cli_options[:log_level] = v }
|
||||
|
||||
opts.on(
|
||||
'--plan FILE',
|
||||
'Follow given plan file, instead of using given git ref/sha'
|
||||
) { |v| cli_options[:plan] = v }
|
||||
def self.parse(args)
|
||||
inst = new
|
||||
inst.parse!(args)
|
||||
inst.options
|
||||
end
|
||||
|
||||
begin
|
||||
parser.parse!
|
||||
def parse!(args)
|
||||
parser.parse!(args)
|
||||
rescue OptionParser::InvalidOption => e
|
||||
fatal e.message
|
||||
end
|
||||
|
||||
Output.log_level = cli_options[:log_level]
|
||||
def options
|
||||
@options ||= defaults.dup.tap do |o|
|
||||
o.each { |k, v| o[k] = v.dup if v.is_a?(Array) }
|
||||
end
|
||||
end
|
||||
|
||||
def defaults
|
||||
{
|
||||
work_dir: File.expand_path(__dir__),
|
||||
native_full_aot: false,
|
||||
relink_eln: true,
|
||||
native_march: false,
|
||||
parallel: Etc.nprocessors,
|
||||
rsvg: true,
|
||||
dbus: true,
|
||||
use_nix: !ENV.fetch('IN_NIX_SHELL', '').empty?,
|
||||
xwidgets: true,
|
||||
tree_sitter: true,
|
||||
fd_setsize: 10_000,
|
||||
github_src_repo: nil,
|
||||
github_auth: true,
|
||||
dist_include: ['COPYING', 'configure_output.txt'],
|
||||
self_sign: true,
|
||||
archive: true,
|
||||
archive_keep: false,
|
||||
patches: [],
|
||||
log_level: 'info'
|
||||
}
|
||||
end
|
||||
|
||||
def parser
|
||||
@parser ||= OptionParser.new do |opts|
|
||||
opts.banner = <<~DOC
|
||||
Usage: ./build-emacs-for-macos [options] <branch/tag/sha>
|
||||
|
||||
Branch, tag, and SHA are from the emacs-mirror/emacs/emacs Github repo,
|
||||
available here: https://github.com/emacs-mirror/emacs
|
||||
|
||||
Options:
|
||||
DOC
|
||||
|
||||
opts.on(
|
||||
'--info',
|
||||
'Print environment info and detected library paths, then exit'
|
||||
) { |v| options[:info] = v }
|
||||
|
||||
opts.on(
|
||||
'--preview',
|
||||
'Print preview details about build and exit.'
|
||||
) { |v| options[:preview] = v }
|
||||
|
||||
opts.on(
|
||||
'-j',
|
||||
'--parallel COUNT',
|
||||
'Compile using COUNT parallel processes ' \
|
||||
"(detected: #{options[:parallel]})"
|
||||
) { |v| options[:parallel] = v }
|
||||
|
||||
opts.on(
|
||||
'--git-sha SHA',
|
||||
'Override detected git SHA of specified ' \
|
||||
'branch allowing builds of old commits'
|
||||
) { |v| options[:git_sha] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]use-nix',
|
||||
'Use Nix instead of Homebrew to find dependencies ' \
|
||||
'(default: enabled if IN_NIX_SHELL is set)'
|
||||
) { |v| options[:use_nix] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]tree-sitter',
|
||||
'Enable/disable tree-sitter if supported ' \
|
||||
'(default: enabled)'
|
||||
) { |v| options[:tree_sitter] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]native-comp',
|
||||
'Enable/disable native-comp ' \
|
||||
'(default: enabled if supported)'
|
||||
) { |v| options[:native_comp] = v }
|
||||
|
||||
opts.on(
|
||||
'--optimize',
|
||||
'Shorthand for --native-march --native-mtune --fomit-frame-pointer ' \
|
||||
'(default: disabled)'
|
||||
) do
|
||||
options[:native_march] = true
|
||||
options[:native_mtune] = true
|
||||
options[:fomit_frame_pointer] = true
|
||||
end
|
||||
|
||||
opts.on(
|
||||
'--[no-]native-march',
|
||||
'Enable/disable -march=native CFLAG ' \
|
||||
'(default: disabled)'
|
||||
) { |v| options[:native_march] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]native-mtune',
|
||||
'Enable/disable -mtune=native CFLAG ' \
|
||||
'(default: disabled)'
|
||||
) { |v| options[:native_mtune] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]fomit-frame-pointer',
|
||||
'Enable/disable -fomit-frame-pointer CFLAG ' \
|
||||
'(default: disabled)'
|
||||
) { |v| options[:fomit_frame_pointer] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]native-full-aot',
|
||||
'Enable/disable NATIVE_FULL_AOT / Ahead of Time compilation ' \
|
||||
'(default: disabled)'
|
||||
) { |v| options[:native_full_aot] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]relink-eln-files',
|
||||
'Enable/disable re-linking shared libraries in bundled *.eln ' \
|
||||
'files (default: enabled)'
|
||||
) { |v| options[:relink_eln] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]rsvg',
|
||||
'Enable/disable SVG image support via librsvg ' \
|
||||
'(default: enabled)'
|
||||
) { |v| options[:rsvg] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]dbus',
|
||||
'Enable/disable dbus support (default: enabled)'
|
||||
) { |v| options[:dbus] = v }
|
||||
|
||||
opts.on(
|
||||
'--alpha-background',
|
||||
'Apply experimental alpha-background patch when building Emacs ' \
|
||||
'30.x - 31.x (default: disabled)'
|
||||
) { |v| options[:alpha_background] = v }
|
||||
|
||||
opts.on(
|
||||
'--no-frame-refocus',
|
||||
'Apply no-frame-refocus patch when building Emacs 27.x - 31.x ' \
|
||||
'(default: disabled)'
|
||||
) { options[:no_frame_refocus] = true }
|
||||
|
||||
opts.on(
|
||||
'--no-titlebar',
|
||||
'Apply no-titlebar patch when building Emacs 27.x - 28.x ' \
|
||||
'(default: disabled)'
|
||||
) { options[:no_titlebar] = true }
|
||||
|
||||
opts.on(
|
||||
'--[no-]xwidgets',
|
||||
'Enable/disable XWidgets when building Emacs 27.x ' \
|
||||
'(default: disabled)'
|
||||
) { |v| options[:xwidgets] = v }
|
||||
|
||||
opts.on('--[no-]poll', 'Apply poll patch (deprecated)') do
|
||||
warn '==> WARN: poll patch is deprecated and has no effect.'
|
||||
end
|
||||
|
||||
opts.on('--posix-spawn', 'Apply posix-spawn patch (deprecated)') do
|
||||
warn '==> WARN: posix-spawn patch is deprecated and has no effect.'
|
||||
end
|
||||
|
||||
opts.on(
|
||||
'-p=URL', '--patch=URL',
|
||||
'Specify a custom patch file or URL to apply to the Emacs source ' \
|
||||
'(can be used multiple times)'
|
||||
) do |v|
|
||||
if !valid_url?(v) && !File.exist?(v)
|
||||
fatal "Patch is not a URL or file: #{v}"
|
||||
end
|
||||
options[:patches] << v
|
||||
end
|
||||
|
||||
opts.on(
|
||||
'--[no-]fd-setsize SIZE',
|
||||
'Set an file descriptor (max open files) limit (default: 10000)'
|
||||
) { |v| options[:fd_setsize] = v.respond_to?(:to_i) ? v.to_i : 0 }
|
||||
|
||||
opts.on(
|
||||
'--github-src-repo REPO',
|
||||
'Specify a GitHub repo to download source tarballs from ' \
|
||||
'(default: emacs-mirror/emacs)'
|
||||
) { |v| options[:github_src_repo] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]github-auth',
|
||||
'Make authenticated GitHub API requests if GITHUB_TOKEN ' \
|
||||
'environment variable is set.' \
|
||||
'(default: enabled)'
|
||||
) { |v| options[:github_auth] = v }
|
||||
|
||||
opts.on(
|
||||
'--work-dir DIR',
|
||||
'Specify a working directory where tarballs, sources, and ' \
|
||||
'builds will be stored and worked with'
|
||||
) { |v| options[:work_dir] = v }
|
||||
|
||||
opts.on(
|
||||
'-o DIR',
|
||||
'--output DIR',
|
||||
'Output directory for finished builds ' \
|
||||
'(default: <work-dir>/builds)'
|
||||
) { |v| options[:output] = v }
|
||||
|
||||
opts.on('--build-name NAME', 'Override generated build name') do |v|
|
||||
options[:build_name] = v
|
||||
end
|
||||
|
||||
opts.on(
|
||||
'--dist-include x,y,z',
|
||||
'List of extra files to copy from Emacs source into build ' \
|
||||
'folder/archive (default: COPYING)'
|
||||
) { |v| options[:dist_include] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]self-sign',
|
||||
'Enable/disable self-signing of Emacs.app (default: enabled)'
|
||||
) { |v| options[:self_sign] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]archive',
|
||||
'Enable/disable creating *.tbz archive (default: enabled)'
|
||||
) { |v| options[:archive] = v }
|
||||
|
||||
opts.on(
|
||||
'--[no-]archive-keep-build-dir',
|
||||
'Enable/disable keeping source folder for archive ' \
|
||||
'(default: disabled)'
|
||||
) { |v| options[:archive_keep] = v }
|
||||
|
||||
opts.on(
|
||||
'--log-level LEVEL',
|
||||
'Build script log level (default: info)'
|
||||
) { |v| options[:log_level] = v }
|
||||
|
||||
opts.on(
|
||||
'--plan FILE',
|
||||
'Follow given plan file, instead of using given git ref/sha'
|
||||
) { |v| options[:plan] = v }
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
if __FILE__ == $PROGRAM_NAME
|
||||
begin
|
||||
cli_options = CLIOptions.parse(ARGV)
|
||||
|
||||
Output.log_level = cli_options.delete(:log_level)
|
||||
work_dir = cli_options.delete(:work_dir)
|
||||
build = Build.new(work_dir, ARGV.shift, cli_options)
|
||||
|
||||
|
||||
8
flake.lock
generated
8
flake.lock
generated
@@ -20,16 +20,16 @@
|
||||
},
|
||||
"nixpkgs": {
|
||||
"locked": {
|
||||
"lastModified": 1731603435,
|
||||
"narHash": "sha256-CqCX4JG7UiHvkrBTpYC3wcEurvbtTADLbo3Ns2CEoL8=",
|
||||
"lastModified": 1732981179,
|
||||
"narHash": "sha256-F7thesZPvAMSwjRu0K8uFshTk3ZZSNAsXTIFvXBT+34=",
|
||||
"owner": "NixOS",
|
||||
"repo": "nixpkgs",
|
||||
"rev": "8b27c1239e5c421a2bbc2c65d52e4a6fbf2ff296",
|
||||
"rev": "62c435d93bf046a5396f3016472e8f7c8e2aed65",
|
||||
"type": "github"
|
||||
},
|
||||
"original": {
|
||||
"owner": "NixOS",
|
||||
"ref": "24.11-beta",
|
||||
"ref": "nixos-24.11",
|
||||
"repo": "nixpkgs",
|
||||
"type": "github"
|
||||
}
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
description = "Development environment flake";
|
||||
|
||||
inputs = {
|
||||
nixpkgs.url = "github:NixOS/nixpkgs/24.11-beta";
|
||||
nixpkgs.url = "github:NixOS/nixpkgs/nixos-24.11";
|
||||
flake-utils.url = "github:numtide/flake-utils";
|
||||
};
|
||||
|
||||
|
||||
487
patches/emacs-29/ns-alpha-background.patch
Normal file
487
patches/emacs-29/ns-alpha-background.patch
Normal file
@@ -0,0 +1,487 @@
|
||||
From 9b436ccb00ea321fe778ea51cf1ad536aff7210f Mon Sep 17 00:00:00 2001
|
||||
From: Jon Rubens <jonathanrubens@gmail.com>
|
||||
Date: Wed, 24 Jan 2024 19:45:55 -0800
|
||||
Subject: [PATCH 1/3] Enable frame parameter alpha_background for MacOS
|
||||
|
||||
---
|
||||
src/macfont.m | 10 ++++++++--
|
||||
src/nsfns.m | 42 ++++++++++++++++++++++++++++++++++--------
|
||||
src/nsterm.m | 42 ++++++++++++++++++++++--------------------
|
||||
3 files changed, 64 insertions(+), 30 deletions(-)
|
||||
|
||||
diff --git a/src/macfont.m b/src/macfont.m
|
||||
index 8aba440d196e..56c1eb57024e 100644
|
||||
--- a/src/macfont.m
|
||||
+++ b/src/macfont.m
|
||||
@@ -2953,9 +2953,14 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no
|
||||
CG_SET_FILL_COLOR_WITH_FACE_FOREGROUND (context, face);
|
||||
else
|
||||
CG_SET_FILL_COLOR_WITH_FRAME_CURSOR (context, f);
|
||||
- }
|
||||
+ CGContextSetAlpha(context, 1);
|
||||
+ }
|
||||
else
|
||||
- CG_SET_FILL_COLOR_WITH_FACE_BACKGROUND (context, face);
|
||||
+ {
|
||||
+ CGContextSetAlpha(context, f->alpha_background);
|
||||
+ CG_SET_FILL_COLOR_WITH_FACE_BACKGROUND (context, face);
|
||||
+ }
|
||||
+ CGContextClearRect(context, background_rect);
|
||||
CGContextFillRects (context, &background_rect, 1);
|
||||
}
|
||||
|
||||
@@ -2964,6 +2969,7 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no
|
||||
CGAffineTransform atfm;
|
||||
|
||||
CGContextScaleCTM (context, 1, -1);
|
||||
+ CGContextSetAlpha(context, 1);
|
||||
if (s->hl == DRAW_CURSOR)
|
||||
{
|
||||
if (face && (NS_FACE_BACKGROUND (face)
|
||||
diff --git a/src/nsfns.m b/src/nsfns.m
|
||||
index b0281aac2572..3e19cce89de9 100644
|
||||
--- a/src/nsfns.m
|
||||
+++ b/src/nsfns.m
|
||||
@@ -301,7 +301,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side.
|
||||
struct face *face;
|
||||
NSColor *col;
|
||||
NSView *view = FRAME_NS_VIEW (f);
|
||||
- EmacsCGFloat alpha;
|
||||
+ EmacsCGFloat alpha = f->alpha_background;
|
||||
|
||||
block_input ();
|
||||
if (ns_lisp_to_color (arg, &col))
|
||||
@@ -316,11 +316,10 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side.
|
||||
f->output_data.ns->background_color = col;
|
||||
|
||||
FRAME_BACKGROUND_PIXEL (f) = [col unsignedLong];
|
||||
- alpha = [col alphaComponent];
|
||||
|
||||
if (view != nil)
|
||||
{
|
||||
- [[view window] setBackgroundColor: col];
|
||||
+ [[view window] setBackgroundColor: [col colorWithAlphaComponent: alpha]];
|
||||
|
||||
if (alpha != (EmacsCGFloat) 1.0)
|
||||
[[view window] setOpaque: NO];
|
||||
@@ -330,10 +329,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side.
|
||||
face = FRAME_DEFAULT_FACE (f);
|
||||
if (face)
|
||||
{
|
||||
- col = [NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)];
|
||||
- face->background = [[col colorWithAlphaComponent: alpha]
|
||||
- unsignedLong];
|
||||
-
|
||||
+ face->background = [col unsignedLong];
|
||||
update_face_from_frame_parameter (f, Qbackground_color, arg);
|
||||
}
|
||||
|
||||
@@ -346,6 +342,36 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side.
|
||||
unblock_input ();
|
||||
}
|
||||
|
||||
+static void
|
||||
+ns_set_alpha_background (struct frame *f, Lisp_Object arg, Lisp_Object oldval)
|
||||
+{
|
||||
+ NSView *view = FRAME_NS_VIEW (f);
|
||||
+ double alpha = 1.0;
|
||||
+
|
||||
+ if (NILP (arg))
|
||||
+ alpha = 1.0;
|
||||
+ else if (FLOATP (arg))
|
||||
+ {
|
||||
+ alpha = XFLOAT_DATA (arg);
|
||||
+ if (! (0 <= alpha && alpha <= 1.0))
|
||||
+ args_out_of_range (make_float (0.0), make_float (1.0));
|
||||
+ }
|
||||
+ else if (FIXNUMP (arg))
|
||||
+ {
|
||||
+ EMACS_INT ialpha = XFIXNUM (arg);
|
||||
+ if (! (0 <= ialpha && ialpha <= 100))
|
||||
+ args_out_of_range (make_fixnum (0), make_fixnum (100));
|
||||
+ alpha = ialpha / 100.0;
|
||||
+ }
|
||||
+ else
|
||||
+ wrong_type_argument (Qnumberp, arg);
|
||||
+
|
||||
+ f->alpha_background = alpha;
|
||||
+ [[view window] setBackgroundColor: [f->output_data.ns->background_color
|
||||
+ colorWithAlphaComponent: alpha]];
|
||||
+ recompute_basic_faces (f);
|
||||
+ SET_FRAME_GARBAGED (f);
|
||||
+}
|
||||
|
||||
static void
|
||||
ns_set_cursor_color (struct frame *f, Lisp_Object arg, Lisp_Object oldval)
|
||||
@@ -1065,7 +1091,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side.
|
||||
ns_set_z_group,
|
||||
0, /* x_set_override_redirect */
|
||||
gui_set_no_special_glyphs,
|
||||
- gui_set_alpha_background,
|
||||
+ ns_set_alpha_background,
|
||||
NULL,
|
||||
#ifdef NS_IMPL_COCOA
|
||||
ns_set_appearance,
|
||||
diff --git a/src/nsterm.m b/src/nsterm.m
|
||||
index 518b38658d17..bda3a12172f5 100644
|
||||
--- a/src/nsterm.m
|
||||
+++ b/src/nsterm.m
|
||||
@@ -2618,8 +2618,9 @@ Hide the window (X11 semantics)
|
||||
|
||||
block_input ();
|
||||
ns_focus (f, &r, 1);
|
||||
- [[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND
|
||||
- (FACE_FROM_ID (f, DEFAULT_FACE_ID))] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND
|
||||
+ (FACE_FROM_ID (f, DEFAULT_FACE_ID))]
|
||||
+ colorWithAlphaComponent: f->alpha_background] set];
|
||||
NSRectFill (r);
|
||||
ns_unfocus (f);
|
||||
|
||||
@@ -2647,7 +2648,7 @@ Hide the window (X11 semantics)
|
||||
|
||||
r = NSIntersectionRect (r, [view frame]);
|
||||
ns_focus (f, &r, 1);
|
||||
- [[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: f->alpha_background] set];
|
||||
|
||||
NSRectFill (r);
|
||||
|
||||
@@ -2751,7 +2752,7 @@ Hide the window (X11 semantics)
|
||||
return;
|
||||
|
||||
ns_focus (f, NULL, 1);
|
||||
- [[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: f->alpha_background] set];
|
||||
NSRectFill (NSMakeRect (0, margin, width, border));
|
||||
NSRectFill (NSMakeRect (0, 0, border, height));
|
||||
NSRectFill (NSMakeRect (0, margin, width, border));
|
||||
@@ -2802,7 +2803,7 @@ Hide the window (X11 semantics)
|
||||
NSRect r = NSMakeRect (0, y, FRAME_PIXEL_WIDTH (f), height);
|
||||
ns_focus (f, &r, 1);
|
||||
|
||||
- [[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: f->alpha_background] set];
|
||||
NSRectFill (NSMakeRect (0, y, width, height));
|
||||
NSRectFill (NSMakeRect (FRAME_PIXEL_WIDTH (f) - width,
|
||||
y, width, height));
|
||||
@@ -2966,8 +2967,7 @@ Hide the window (X11 semantics)
|
||||
if (! NSIsEmptyRect (clearRect))
|
||||
{
|
||||
NSTRACE_RECT ("clearRect", clearRect);
|
||||
-
|
||||
- [[NSColor colorWithUnsignedLong:face->background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:face->background] colorWithAlphaComponent: f->alpha_background] set];
|
||||
NSRectFill (clearRect);
|
||||
}
|
||||
|
||||
@@ -2998,7 +2998,7 @@ Hide the window (X11 semantics)
|
||||
else
|
||||
bm_color = f->output_data.ns->cursor_color;
|
||||
|
||||
- [bm_color set];
|
||||
+ [[bm_color colorWithAlphaComponent:f->alpha_background] set];
|
||||
[bmp fill];
|
||||
|
||||
[bmp release];
|
||||
@@ -3719,7 +3719,7 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
if (s->face->box == FACE_SIMPLE_BOX && s->face->box_color)
|
||||
{
|
||||
ns_draw_box (r, abs (hthickness), abs (vthickness),
|
||||
- [NSColor colorWithUnsignedLong:face->box_color],
|
||||
+ [[NSColor colorWithUnsignedLong:face->box_color] colorWithAlphaComponent: s->f->alpha_background],
|
||||
left_p, right_p);
|
||||
}
|
||||
else
|
||||
@@ -3757,8 +3757,10 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
{
|
||||
if (s->hl != DRAW_CURSOR)
|
||||
[(NS_FACE_BACKGROUND (face) != 0
|
||||
- ? [NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)]
|
||||
+ ? [[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)]
|
||||
+ colorWithAlphaComponent: s->f->alpha_background]
|
||||
: FRAME_BACKGROUND_COLOR (s->f)) set];
|
||||
+
|
||||
else if (face && (NS_FACE_BACKGROUND (face)
|
||||
== [(NSColor *) FRAME_CURSOR_COLOR (s->f)
|
||||
unsignedLong]))
|
||||
@@ -3902,7 +3904,7 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
otherwise, since we composite the image under NS (instead of mucking
|
||||
with its background color), we must clear just the image area. */
|
||||
|
||||
- [[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
|
||||
if (bg_height > s->slice.height || s->img->hmargin || s->img->vmargin
|
||||
|| s->img->mask || s->img->pixmap == 0 || s->width != s->background_width)
|
||||
@@ -3972,7 +3974,7 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
if (s->hl == DRAW_CURSOR)
|
||||
{
|
||||
[FRAME_CURSOR_COLOR (s->f) set];
|
||||
- tdCol = [NSColor colorWithUnsignedLong: NS_FACE_BACKGROUND (face)];
|
||||
+ tdCol = [[NSColor colorWithUnsignedLong: NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: s->f->alpha_background];
|
||||
}
|
||||
else
|
||||
tdCol = [NSColor colorWithUnsignedLong: NS_FACE_FOREGROUND (face)];
|
||||
@@ -4066,10 +4068,10 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
face = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
|
||||
prepare_face_for_display (s->f, face);
|
||||
|
||||
- [[NSColor colorWithUnsignedLong: face->background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong: face->background] colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
}
|
||||
else
|
||||
- [[NSColor colorWithUnsignedLong: s->face->background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong: s->face->background] colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
NSRectFill (NSMakeRect (x, y, w, h));
|
||||
}
|
||||
}
|
||||
@@ -4095,7 +4097,7 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
if (s->hl == DRAW_CURSOR)
|
||||
[FRAME_CURSOR_COLOR (s->f) set];
|
||||
else
|
||||
- [[NSColor colorWithUnsignedLong: s->face->background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong: s->face->background] colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
|
||||
NSRectFill (NSMakeRect (x, s->y, background_width, s->height));
|
||||
}
|
||||
@@ -8436,8 +8438,8 @@ - (void)toggleFullScreen: (id)sender
|
||||
}
|
||||
|
||||
[w setContentView:[fw contentView]];
|
||||
- [w setBackgroundColor: col];
|
||||
- if ([col alphaComponent] != (EmacsCGFloat) 1.0)
|
||||
+ [w setBackgroundColor: [col colorWithAlphaComponent: f->alpha_background]];
|
||||
+ if (f->alpha_background != (EmacsCGFloat) 1.0)
|
||||
[w setOpaque: NO];
|
||||
|
||||
f->border_width = [w borderWidth];
|
||||
@@ -9172,9 +9174,9 @@ - (instancetype) initWithEmacsFrame: (struct frame *) f
|
||||
f->border_width = [self borderWidth];
|
||||
|
||||
col = [NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND
|
||||
- (FACE_FROM_ID (f, DEFAULT_FACE_ID))];
|
||||
- [self setBackgroundColor:col];
|
||||
- if ([col alphaComponent] != (EmacsCGFloat) 1.0)
|
||||
+ (FACE_FROM_ID (f, DEFAULT_FACE_ID))];
|
||||
+ [self setBackgroundColor:[col colorWithAlphaComponent:f->alpha_background]];
|
||||
+ if (f->alpha_background != (EmacsCGFloat) 1.0)
|
||||
[self setOpaque:NO];
|
||||
|
||||
/* toolbar support */
|
||||
|
||||
From 58cf6e6da20eefca161c1ab1fd0d6ad67d1ba710 Mon Sep 17 00:00:00 2001
|
||||
From: Jon Rubens <jonathanrubens@gmail.com>
|
||||
Date: Fri, 26 Jan 2024 09:35:15 -0800
|
||||
Subject: [PATCH 2/3] Fix code formatting
|
||||
|
||||
---
|
||||
src/macfont.m | 8 ++++----
|
||||
src/nsterm.m | 30 ++++++++++++++++++++----------
|
||||
2 files changed, 24 insertions(+), 14 deletions(-)
|
||||
|
||||
diff --git a/src/macfont.m b/src/macfont.m
|
||||
index 56c1eb57024e..8fb835c7ff01 100644
|
||||
--- a/src/macfont.m
|
||||
+++ b/src/macfont.m
|
||||
@@ -2953,14 +2953,14 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no
|
||||
CG_SET_FILL_COLOR_WITH_FACE_FOREGROUND (context, face);
|
||||
else
|
||||
CG_SET_FILL_COLOR_WITH_FRAME_CURSOR (context, f);
|
||||
- CGContextSetAlpha(context, 1);
|
||||
+ CGContextSetAlpha (context, 1);
|
||||
}
|
||||
else
|
||||
{
|
||||
- CGContextSetAlpha(context, f->alpha_background);
|
||||
+ CGContextSetAlpha (context, f->alpha_background);
|
||||
CG_SET_FILL_COLOR_WITH_FACE_BACKGROUND (context, face);
|
||||
}
|
||||
- CGContextClearRect(context, background_rect);
|
||||
+ CGContextClearRect (context, background_rect);
|
||||
CGContextFillRects (context, &background_rect, 1);
|
||||
}
|
||||
|
||||
@@ -2969,7 +2969,7 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no
|
||||
CGAffineTransform atfm;
|
||||
|
||||
CGContextScaleCTM (context, 1, -1);
|
||||
- CGContextSetAlpha(context, 1);
|
||||
+ CGContextSetAlpha (context, 1);
|
||||
if (s->hl == DRAW_CURSOR)
|
||||
{
|
||||
if (face && (NS_FACE_BACKGROUND (face)
|
||||
diff --git a/src/nsterm.m b/src/nsterm.m
|
||||
index bda3a12172f5..9ab3ff8f783f 100644
|
||||
--- a/src/nsterm.m
|
||||
+++ b/src/nsterm.m
|
||||
@@ -2803,7 +2803,8 @@ Hide the window (X11 semantics)
|
||||
NSRect r = NSMakeRect (0, y, FRAME_PIXEL_WIDTH (f), height);
|
||||
ns_focus (f, &r, 1);
|
||||
|
||||
- [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: f->alpha_background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)]
|
||||
+ colorWithAlphaComponent: f->alpha_background] set];
|
||||
NSRectFill (NSMakeRect (0, y, width, height));
|
||||
NSRectFill (NSMakeRect (FRAME_PIXEL_WIDTH (f) - width,
|
||||
y, width, height));
|
||||
@@ -2967,7 +2968,8 @@ Hide the window (X11 semantics)
|
||||
if (! NSIsEmptyRect (clearRect))
|
||||
{
|
||||
NSTRACE_RECT ("clearRect", clearRect);
|
||||
- [[[NSColor colorWithUnsignedLong:face->background] colorWithAlphaComponent: f->alpha_background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:face->background]
|
||||
+ colorWithAlphaComponent: f->alpha_background] set];
|
||||
NSRectFill (clearRect);
|
||||
}
|
||||
|
||||
@@ -3719,7 +3721,8 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
if (s->face->box == FACE_SIMPLE_BOX && s->face->box_color)
|
||||
{
|
||||
ns_draw_box (r, abs (hthickness), abs (vthickness),
|
||||
- [[NSColor colorWithUnsignedLong:face->box_color] colorWithAlphaComponent: s->f->alpha_background],
|
||||
+ [[NSColor colorWithUnsignedLong:face->box_color]
|
||||
+ colorWithAlphaComponent: s->f->alpha_background],
|
||||
left_p, right_p);
|
||||
}
|
||||
else
|
||||
@@ -3904,7 +3907,8 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
otherwise, since we composite the image under NS (instead of mucking
|
||||
with its background color), we must clear just the image area. */
|
||||
|
||||
- [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)]
|
||||
+ colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
|
||||
if (bg_height > s->slice.height || s->img->hmargin || s->img->vmargin
|
||||
|| s->img->mask || s->img->pixmap == 0 || s->width != s->background_width)
|
||||
@@ -3974,7 +3978,8 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
if (s->hl == DRAW_CURSOR)
|
||||
{
|
||||
[FRAME_CURSOR_COLOR (s->f) set];
|
||||
- tdCol = [[NSColor colorWithUnsignedLong: NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: s->f->alpha_background];
|
||||
+ tdCol = [[NSColor colorWithUnsignedLong: NS_FACE_BACKGROUND (face)]
|
||||
+ colorWithAlphaComponent: s->f->alpha_background];
|
||||
}
|
||||
else
|
||||
tdCol = [NSColor colorWithUnsignedLong: NS_FACE_FOREGROUND (face)];
|
||||
@@ -4068,10 +4073,12 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
face = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
|
||||
prepare_face_for_display (s->f, face);
|
||||
|
||||
- [[[NSColor colorWithUnsignedLong: face->background] colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong: face->background]
|
||||
+ colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
}
|
||||
else
|
||||
- [[[NSColor colorWithUnsignedLong: s->face->background] colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong: s->face->background]
|
||||
+ colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
NSRectFill (NSMakeRect (x, y, w, h));
|
||||
}
|
||||
}
|
||||
@@ -4097,7 +4104,8 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
if (s->hl == DRAW_CURSOR)
|
||||
[FRAME_CURSOR_COLOR (s->f) set];
|
||||
else
|
||||
- [[[NSColor colorWithUnsignedLong: s->face->background] colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong: s->face->background]
|
||||
+ colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
|
||||
NSRectFill (NSMakeRect (x, s->y, background_width, s->height));
|
||||
}
|
||||
@@ -8438,7 +8446,8 @@ - (void)toggleFullScreen: (id)sender
|
||||
}
|
||||
|
||||
[w setContentView:[fw contentView]];
|
||||
- [w setBackgroundColor: [col colorWithAlphaComponent: f->alpha_background]];
|
||||
+ [w setBackgroundColor: [col colorWithAlphaComponent:
|
||||
+ f->alpha_background]];
|
||||
if (f->alpha_background != (EmacsCGFloat) 1.0)
|
||||
[w setOpaque: NO];
|
||||
|
||||
@@ -9175,7 +9184,8 @@ - (instancetype) initWithEmacsFrame: (struct frame *) f
|
||||
|
||||
col = [NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND
|
||||
(FACE_FROM_ID (f, DEFAULT_FACE_ID))];
|
||||
- [self setBackgroundColor:[col colorWithAlphaComponent:f->alpha_background]];
|
||||
+ [self setBackgroundColor:
|
||||
+ [col colorWithAlphaComponent:f->alpha_background]];
|
||||
if (f->alpha_background != (EmacsCGFloat) 1.0)
|
||||
[self setOpaque:NO];
|
||||
|
||||
|
||||
From 896596aac2932ab98dbeb68f48a963275fdb76c5 Mon Sep 17 00:00:00 2001
|
||||
From: Jon Rubens <jonathanrubens@gmail.com>
|
||||
Date: Wed, 31 Jan 2024 13:30:13 -0800
|
||||
Subject: [PATCH 3/3] More code formatting
|
||||
|
||||
---
|
||||
src/nsfns.m | 11 ++++++-----
|
||||
src/nsterm.m | 8 +++++---
|
||||
2 files changed, 11 insertions(+), 8 deletions(-)
|
||||
|
||||
diff --git a/src/nsfns.m b/src/nsfns.m
|
||||
index 3e19cce89de9..67d8449c70dd 100644
|
||||
--- a/src/nsfns.m
|
||||
+++ b/src/nsfns.m
|
||||
@@ -321,11 +321,6 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side.
|
||||
{
|
||||
[[view window] setBackgroundColor: [col colorWithAlphaComponent: alpha]];
|
||||
|
||||
- if (alpha != (EmacsCGFloat) 1.0)
|
||||
- [[view window] setOpaque: NO];
|
||||
- else
|
||||
- [[view window] setOpaque: YES];
|
||||
-
|
||||
face = FRAME_DEFAULT_FACE (f);
|
||||
if (face)
|
||||
{
|
||||
@@ -369,6 +364,12 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side.
|
||||
f->alpha_background = alpha;
|
||||
[[view window] setBackgroundColor: [f->output_data.ns->background_color
|
||||
colorWithAlphaComponent: alpha]];
|
||||
+
|
||||
+ if (alpha != (EmacsCGFloat) 1.0)
|
||||
+ [[view window] setOpaque: NO];
|
||||
+ else
|
||||
+ [[view window] setOpaque: YES];
|
||||
+
|
||||
recompute_basic_faces (f);
|
||||
SET_FRAME_GARBAGED (f);
|
||||
}
|
||||
diff --git a/src/nsterm.m b/src/nsterm.m
|
||||
index 9ab3ff8f783f..6feef6236449 100644
|
||||
--- a/src/nsterm.m
|
||||
+++ b/src/nsterm.m
|
||||
@@ -2648,9 +2648,11 @@ Hide the window (X11 semantics)
|
||||
|
||||
r = NSIntersectionRect (r, [view frame]);
|
||||
ns_focus (f, &r, 1);
|
||||
- [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: f->alpha_background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)]
|
||||
+ colorWithAlphaComponent: f->alpha_background] set];
|
||||
|
||||
NSRectFill (r);
|
||||
+ [[view window] invalidateShadow];
|
||||
|
||||
ns_unfocus (f);
|
||||
return;
|
||||
@@ -2752,7 +2754,8 @@ Hide the window (X11 semantics)
|
||||
return;
|
||||
|
||||
ns_focus (f, NULL, 1);
|
||||
- [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)] colorWithAlphaComponent: f->alpha_background] set];
|
||||
+ [[[NSColor colorWithUnsignedLong:NS_FACE_BACKGROUND (face)]
|
||||
+ colorWithAlphaComponent: f->alpha_background] set];
|
||||
NSRectFill (NSMakeRect (0, margin, width, border));
|
||||
NSRectFill (NSMakeRect (0, 0, border, height));
|
||||
NSRectFill (NSMakeRect (0, margin, width, border));
|
||||
@@ -4106,7 +4109,6 @@ Function modeled after x_draw_glyph_string_box ().
|
||||
else
|
||||
[[[NSColor colorWithUnsignedLong: s->face->background]
|
||||
colorWithAlphaComponent: s->f->alpha_background] set];
|
||||
-
|
||||
NSRectFill (NSMakeRect (x, s->y, background_width, s->height));
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user