make Buffer#queue a private method as it's never supposed to be modified or read from outside of the Buffer object

This commit is contained in:
2011-04-18 10:00:22 +01:00
parent 4b06513813
commit b129074cd7
2 changed files with 9 additions and 9 deletions

View File

@@ -13,10 +13,6 @@ module Redistat
end
attr_writer :size
def queue
@queue ||= {}
end
def store(key, stats, depth_limit, opts)
return false unless should_buffer?
@@ -52,6 +48,10 @@ module Redistat
private
def queue
@queue ||= {}
end
def should_buffer?
size > 1 # buffer size of 1 would be equal to not using buffer
end

View File

@@ -30,20 +30,20 @@ describe Redistat::Buffer do
it "should only flush buffer if buffer size is greater than or equal to buffer size setting" do
@buffer.size.should == 0
@buffer.queue.size.should == 0
@buffer.send(:queue).size.should == 0
@buffer.send(:should_flush?).should be_false
@buffer.queue[:hello] = 'world'
@buffer.send(:queue)[:hello] = 'world'
@buffer.send(:should_flush?).should be_true
@buffer.size = 5
@buffer.send(:should_flush?).should be_false
3.times { |i| @buffer.queue[i] = i.to_s }
3.times { |i| @buffer.send(:queue)[i] = i.to_s }
@buffer.send(:should_flush?).should be_false
@buffer.queue[4] = '4'
@buffer.send(:queue)[4] = '4'
@buffer.send(:should_flush?).should be_true
end
it "should force flush queue irregardless of result of #should_flush? when #reset_queue is called with true" do
@buffer.queue[:hello] = 'world'
@buffer.send(:queue)[:hello] = 'world'
@buffer.send(:should_flush?).should be_true
@buffer.size = 2
@buffer.send(:should_flush?).should be_false