parsecsv/parsecsv-for-php
1
0
Fork 0
mirror of https://github.com/parsecsv/parsecsv-for-php.git synced 2026-02-19 00:36:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes unparse bug if no data for unparsing remain (comments #150)

Browse Source
This commit is contained in:
Susann Sgorzaly
2018-11-13 19:10:10 +01:00
committed by Fonata
parent ab9e8a0af9
commit 52ad56c66a
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Csv.php
View File

@@ -848,8 +848,8 @@ class Csv {
// this is needed because sometime titles property is overwritten instead of using fields parameter!
$titlesOnParse = !empty($this->data) ? array_keys(reset($this->data)) : array();
// both are identical, also in ordering
if (array_values($fields) === array_values($titlesOnParse)) {
// both are identical, also in ordering OR we have no data (only titles)
if (empty($titlesOnParse) || array_values($fields) === array_values($titlesOnParse)) {
return array_combine($fields, $fields);
}

7
tests/methods/UnparseTest.php
View File

@@ -81,6 +81,13 @@ class UnparseTest extends Testcase {
$this->unparseAndCompare($expected);
}
public function testUnparseDefaultWithoutData(){
unset($this->csv->data[0]);
unset($this->csv->data[1]);
$expected = "column1,column2\r";
$this->unparseAndCompare($expected);
}
private function unparseAndCompare($expected, $fields = array()) {
$str = $this->csv->unparse($this->csv->data, $fields);
$this->assertEquals($expected, $str);