review changes

This commit is contained in:
Susann Sgorzaly
2018-02-14 14:03:00 +01:00
parent 8ec87126dc
commit 5babb55879
2 changed files with 9 additions and 11 deletions

View File

@@ -1,6 +1,6 @@
<?php
trait Datatype {
trait DatatypeTrait {
/**
* Datatypes
@@ -53,14 +53,12 @@ trait Datatype {
*
* @access private
*
* @param [array] $datatypes
* @param array $datatypes
*
* @return [string|false]
* @return string|false
*/
private function getMostFrequentDataypeForColumn($datatypes) {
if (isset($datatypes['unknown'])) {
unset($datatypes['unknown']);
}
unset($datatypes['unknown']);
$typesFreq = array_count_values($datatypes);
arsort($typesFreq);
@@ -76,7 +74,7 @@ trait Datatype {
*
* @access public
*
* @return [array|bool]
* @return array|bool
*/
public function getDatatypes() {
if (empty($this->data)) {
@@ -93,6 +91,6 @@ trait Datatype {
$this->data_types = $result;
return !empty($this->data_types) ? $this->data_types : FALSE;
return !empty($this->data_types) ? $this->data_types : false;
}
}

View File

@@ -322,7 +322,7 @@ class parseCSV {
*/
public $data = array();
use Datatype;
use DatatypeTrait;
/**
* Constructor
@@ -469,8 +469,8 @@ class parseCSV {
* Encoding
* Convert character encoding
*
* @param [string] $input Input character encoding, uses default if left blank
* @param [string] $output Output character encoding, uses default if left blank
* @param string $input Input character encoding, uses default if left blank
* @param string $output Output character encoding, uses default if left blank
*/
public function encoding($input = null, $output = null) {
$this->convert_encoding = true;