parsecsv/parsecsv-for-php
1
0
Fork 0
mirror of https://github.com/parsecsv/parsecsv-for-php.git synced 2026-02-19 08:36:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #125 from itexia/42-Heading-and-offset

Browse Source 
Fixed issue 42: heading and offset; added tests
This commit is contained in:
Fonata
2018-03-02 17:06:22 +01:00
committed by GitHub
parent 2ac9f450f1 11b20a3144
commit eedbffc375
2 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Csv.php
View File

@@ -987,7 +987,8 @@ class Csv {
return
$this->sort_by !== null ||
$this->offset === null ||
$current_row >= $this->offset;
$current_row >= $this->offset ||
($this->heading && $current_row == 0);
}
/**

25
tests/methods/ParseTest.php
View File

@@ -157,6 +157,31 @@ class ParseTest extends TestCase
$this->assertEquals($expected, $this->csv->data_types);
}
public function testDataArrayKeysWhenSettingOffsetWithHeading() {
$this->csv->offset = 2;
$this->csv->auto(__DIR__ . '/fixtures/datatype.csv');
$expected = [
'title',
'isbn',
'publishedAt',
'published',
'count',
'price'
];
$this->assertEquals($expected, array_keys($this->csv->data[0]));
}
public function testDataArrayKeysWhenSettingOffsetWithoutHeading() {
$this->csv->heading = false;
$this->csv->offset = 2;
$this->csv->auto(__DIR__ . '/fixtures/datatype.csv');
$expected = range(0,5, 1);
$this->assertEquals($expected, array_keys($this->csv->data[0]));
}
protected function _get_magazines_data() {
return [
[