Bugfix: $csv->parseFile now sets $this->data

This adds consistency because $csv->parse() does the same.

Fix #200
Fix #201
This commit is contained in:
Fonata
2021-05-13 19:42:32 +02:00
committed by Fonata
parent 05826c2bbf
commit 99daaa7235
3 changed files with 23 additions and 1 deletions

View File

@@ -1,3 +1,16 @@
ParseCSV 1.3.1
-----------------------------------
Date: to be released
Bugfix:
- `parseFile()` will now set `$csv->data`.
Until now, the parsed data was only returned.
This adds consistency with `$csv->parse()`
for the following operations on the object.
-----------------------------------
ParseCSV 1.3.0
-----------------------------------
Date: 14-Apr-2021

View File

@@ -621,7 +621,10 @@ class Csv {
return false;
}
return !empty($this->file_data) ? $this->_parse_string() : false;
if (empty($this->file_data)) {
return false;
}
return $this->data = $this->_parse_string();
}
/**

View File

@@ -331,4 +331,10 @@ class ParseTest extends TestCase {
self::assertFalse($this->csv->parseFile(''));
self::assertFalse($this->csv->parseFile(null));
}
public function testParseFile() {
$data = $this->csv->parseFile(__DIR__ . '/fixtures/auto-double-enclosure.csv');
self::assertCount(2, $data);
self::assertEquals($data, $this->csv->data);
}
}